Summary: | RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun.zhang> | ||||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, hausmann, laszlo.gombos | ||||||||
Priority: | P2 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | S60 Emulator | ||||||||||
OS: | S60 3rd edition | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 27065 | ||||||||||
Attachments: |
|
Description
Yongjun Zhang
2009-08-11 10:41:21 PDT
Created attachment 34579 [details]
don't use RenderHint property when building for symbian.
It is a temporary fix, should be reverted when the right symbol is exported from QT lib.
Comment on attachment 34579 [details]
don't use RenderHint property when building for symbian.
The code you're adding should have a FIXME explaining the temporary nature.
You also should file a bug about backing this out (and ideally link to it from your FIXME) Created attachment 34771 [details] Modified patch as per Eric's comments. Thanks for the quick review. I modified the patch as suggested in the comments: 1. created a bug (https://bugs.webkit.org/show_bug.cgi?id=28273) to remind me to revert the change later. 2. added //FIXME comment and link to the above bug. Comment on attachment 34771 [details]
Modified patch as per Eric's comments.
Tab in ChangeLog. r- as that will fail to land.
So is there a bug with upstream Qt about getting this resolved? OR does nokia build some custom S60 Qt, and thus the bug would be with Nokia?
Created attachment 34773 [details]
Remove tab in previous patch (bad copy&paste habbit :) )
This bug will be fixed in upstream Qt for S60. This is a temporary fix to make webkit build with current Qt 4.5.2 for S60.
Do we have a bug number for the upstream fix? Good point Eric, there is a bug number. I'll dig it out tomorrow. Thank you. I just figure it's best that we get all the documentation in the right place now, while we're making the change, instead of 3 years from now, when we're wondering if we can back it out or not. ;) The upstream bug report in Qt is tracked at http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=258893 Comment on attachment 34773 [details]
Remove tab in previous patch (bad copy&paste habbit :) )
r=me
I'll change the url in the comment to the upstream bug url when landing.
Landed in r47285 |