Bug 280886
| Summary: | [JHBuild] Add libspiel to minimal moduleset | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=270742 | ||
| Bug Depends on: | 281397 | ||
| Bug Blocks: | |||
Diego Pino
Changeset 284276@main change speech synthesis from experimental feature to always on. It also changed the speech synthesis backend, from flite2 to libspiel. Libspiel is not packaged in any distro yet. Since the feature was removed from experimental features, the Ubuntu and Debian upstream fails failed after 284276@main. The work around the build failure we disbaledspeech synthesis in the bots (-DENABLE_SPEECH_SYNTHESIS=OFF).
Since speech synthesis is always on now, support for `libspiel` should be added to JHBuild minimal moduleset, for users that would like to build with this build system.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/34696
EWS
Committed 284758@main (30c09a60fec7): <https://commits.webkit.org/284758@main>
Reviewed commits have been landed. Closing PR #34696 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/137420202>
WebKit Commit Bot
Re-opened since this is blocked by bug 281397
Diego Pino
After 285005@main, Libspiel is now optional and it's no longer strictly needed to enable SPEECH_SYNTHESIS. That funcionality is implemented by default by a different backend, Flite2, which is available in every major Linux distribution.