Summary: | Make DOM classes start with a reference count of 1, like all other RefCounted | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | cdumez | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
Bug Depends on: | 44851 | ||||||||||||||||||
Bug Blocks: | 27672, 41321 | ||||||||||||||||||
Attachments: |
|
Description
Darin Adler
2009-08-07 08:15:37 PDT
Created attachment 34274 [details]
work in progress
Created attachment 34532 [details]
patch
Comment on attachment 34532 [details]
patch
Beautiful. r=me.
Comment on attachment 34532 [details] patch Landed as http://trac.webkit.org/changeset/47313 Created attachment 34964 [details]
work in progress
Created attachment 35049 [details]
work in progress
Created attachment 35050 [details]
Factored-out preparation piece
Comment on attachment 35050 [details] Factored-out preparation piece Landed as http://trac.webkit.org/changeset/47469 Created attachment 35112 [details]
patch 2
Comment on attachment 35112 [details]
patch 2
r=me -- in future could you try not to do unrelated code changes -- a lot of
this patch was cleanup (making methods protected or private, etc) and that
clouded a lot of what was going on.
(In reply to comment #10) > (From update of attachment 35112 [details]) > r=me -- in future could you try not to do unrelated code changes -- a lot of > this patch was cleanup (making methods protected or private, etc) and that > clouded a lot of what was going on. I'd be happy to split up patches like this into smaller pieces. could have a separate "make functions private" patch for each class. Or one that covers multiple classes. Comment on attachment 35112 [details] patch 2 Landed as http://trac.webkit.org/changeset/47688 Created attachment 66014 [details]
Patch
Committed r66498: <http://trac.webkit.org/changeset/66498> Mass moving XML DOM bugs to the "DOM" Component. |