Bug 28068

Summary: Make DOM classes start with a reference count of 1, like all other RefCounted
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 44851    
Bug Blocks: 27672, 41321    
Attachments:
Description Flags
work in progress
none
patch
none
work in progress
none
work in progress
none
Factored-out preparation piece
none
patch 2
none
Patch simon.fraser: review+

Description Darin Adler 2009-08-07 08:15:37 PDT
Working on it.
Comment 1 Darin Adler 2009-08-07 08:16:00 PDT
Created attachment 34274 [details]
work in progress
Comment 2 Darin Adler 2009-08-10 18:03:11 PDT
Created attachment 34532 [details]
patch
Comment 3 Sam Weinig 2009-08-14 18:49:51 PDT
Comment on attachment 34532 [details]
patch

Beautiful. r=me.
Comment 4 Darin Adler 2009-08-14 23:26:36 PDT
Comment on attachment 34532 [details]
patch

Landed as http://trac.webkit.org/changeset/47313
Comment 5 Darin Adler 2009-08-17 01:34:48 PDT
Created attachment 34964 [details]
work in progress
Comment 6 Darin Adler 2009-08-18 10:32:27 PDT
Created attachment 35049 [details]
work in progress
Comment 7 Darin Adler 2009-08-18 10:34:19 PDT
Created attachment 35050 [details]
Factored-out preparation piece
Comment 8 Darin Adler 2009-08-18 22:54:07 PDT
Comment on attachment 35050 [details]
Factored-out preparation piece

Landed as http://trac.webkit.org/changeset/47469
Comment 9 Darin Adler 2009-08-19 02:22:40 PDT
Created attachment 35112 [details]
patch 2
Comment 10 Oliver Hunt 2009-08-21 01:33:18 PDT
Comment on attachment 35112 [details]
patch 2

r=me -- in future could you try not to do unrelated code changes -- a lot of
this patch was cleanup (making methods protected or private, etc) and that
clouded a lot of what was going on.
Comment 11 Darin Adler 2009-08-22 23:53:24 PDT
(In reply to comment #10)
> (From update of attachment 35112 [details])
> r=me -- in future could you try not to do unrelated code changes -- a lot of
> this patch was cleanup (making methods protected or private, etc) and that
> clouded a lot of what was going on.

I'd be happy to split up patches like this into smaller pieces. could have a separate "make functions private" patch for each class. Or one that covers multiple classes.
Comment 12 Darin Adler 2009-08-22 23:56:39 PDT
Comment on attachment 35112 [details]
patch 2

Landed as http://trac.webkit.org/changeset/47688
Comment 13 Darin Adler 2010-08-30 22:56:01 PDT
Created attachment 66014 [details]
Patch
Comment 14 Darin Adler 2010-08-31 10:09:07 PDT
Committed r66498: <http://trac.webkit.org/changeset/66498>
Comment 15 Lucas Forschler 2019-02-06 09:03:17 PST
Mass moving XML DOM bugs to the "DOM" Component.