Bug 28065

Summary:

Inherit Noncopyable publicly

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

27879

Attachments:

Description	Flags
proposed patch	none
updated proposed patch	eric: review-

Zoltan Horvath

Reported 2009-08-07 01:44:20 PDT

Since Noncopyable'll be inherited from FastAllocBase, Noncopyable's inheriting has to be changed to public.

Attachments
proposed patch (2.75 KB, patch) 2009-08-07 01:44 PDT, Zoltan Horvath	no flags	Details Formatted Diff Diff
updated proposed patch (2.75 KB, patch) 2009-08-07 01:52 PDT, Zoltan Horvath	eric: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2009-08-07 01:44:57 PDT

Created attachment 34259 [details] proposed patch

Zoltan Horvath

Comment 2 2009-08-07 01:52:39 PDT

Created attachment 34260 [details] updated proposed patch

Eric Seidel (no email)

Comment 3 2009-08-07 08:36:10 PDT

Comment on attachment 34260 [details] updated proposed patch Why? So that new/delete work? Need a couple more words in your ChangeLog. :) Is this all the instances of non-public Noncopybable inheritance?

Zoltan Horvath

Comment 4 2009-08-10 05:58:55 PDT

These classes aren't instantiated by new, after all don't need to inherit from publicly from Noncopyable. I tried to follow changes that have been done in bug #27225 .

Zoltan Horvath

Comment 5 2009-09-01 23:51:30 PDT

So, this patch contains unnecessary changes. I mark it as invalid.

Note You need to log in before you can comment on or make changes to this bug.