Bug 280512 – REGRESSION(284269@main?) [WPE] generate-bundle is failing with assert error

• Component: New Bugs
• Status: RESOLVED FIXED

[Diego Pino]

The script `Tools/Scripts/generate-bundle` is failing after. Taking a look at the error message and latest commit, I believe the regression was introduced by 284269@main, but I haven't confirmed it.

To reproduce the error is necessary to do a build clean of WPE. In my case, I built WPE with JHBuild minimal dependencies moduleset. 

$ Tools/Scripts/generate-bundle --bundle=MiniBrowser --release --platform=wpe --destination=/home/pwuser/webkit/WebKitBuild/webkit-deploy-VNBqNIAhZZ
Traceback (most recent call last):
  File "Tools/Scripts/generate-bundle", line 920, in <module>
    sys.exit(main())
  File "Tools/Scripts/generate-bundle", line 915, in main
    bundle_file_path = bundle_creator.create()
  File "Tools/Scripts/generate-bundle", line 337, in create
    self._create_bundle(bundle_binary)
  File "Tools/Scripts/generate-bundle", line 681, in _create_bundle
    objects_to_copy.append(self._get_webkit_lib('InspectorResources'))
  File "Tools/Scripts/generate-bundle", line 377, in _get_webkit_lib
    assert(bundle_lib)
AssertionError

[Adrian Perez]

Ah, we need to update the script, it currently has:

        if bundle_binary == 'MiniBrowser':
            # bunddle WebKit libraries
            objects_to_copy.extend(self._get_webkit_binaries())
            objects_to_copy.append(self._get_webkit_lib('InjectedBundle'))
            if self._platform == 'wpe':
               objects_to_copy.append(self._get_webkit_lib('InspectorResources'))

Instead of that, we need to pick the inspector.gresource file. Maybe
also check if other scripts need to set WEBKIT_INSPECTOR_RESOURCES_PATH
in the environment to run things from the bundle or uninstalled.

[Diego Pino]

I cannot find `inspector.gresource` file in `WebKitBuild/WPE/Release`. OTOH, file `InspectorGResourceBundle.c` exists in `WebKitBuild/GTK/Release`.

```
$ find WebKitBuild/GTK/Release/ -name "InspectorGResourceBundle.c"
WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/InspectorGResourceBundle.c
```

[Adrian Perez]

(In reply to Diego Pino from comment #2)
> I cannot find `inspector.gresource` file in `WebKitBuild/WPE/Release`. OTOH,
> file `InspectorGResourceBundle.c` exists in `WebKitBuild/GTK/Release`.
> 
> ```
> $ find WebKitBuild/GTK/Release/ -name "InspectorGResourceBundle.c"
> WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/InspectorGResourceBundle.c
> ```

That's expected: the GTK port compiles the .c file into libwebkitgtk-6.0.so
and only the WPE port has been changed to produce inspector.gresource

[Diego Pino]

> That's expected: the GTK port compiles the .c file into libwebkitgtk-6.0.so
> and only the WPE port has been changed to produce inspector.gresource

Ok, so now WPE should produce a file called 'inspector.gresource'. Agree. However, what I mentioned is that after building WPE I cannot find any file called 'inspector.gresource' in 'WebKitBuild/WPE/Release'. Maybe I'm looking in the wrong place. Where should be this file?

[Diego Pino]

The generation of 'inspector.gresource' file was fixed by Lauro in https://github.com/WebKit/WebKit/pull/34409

[Diego Pino]

After apply the patch by Lauro, the command:

```
Tools/Scripts/generate-bundle --bundle=MiniBrowser --release --platform=wpe --destination=/home/pwuser/webkit/WebKitBuild/webkit-deploy-VNBqNIAhZZ
```

finished successfully.

I'm not sure if Lauro's patch is enough or more changes are needed, like the ones mentioned by Adrian in https://bugs.webkit.org/show_bug.cgi?id=280512#c1

[Diego Pino]

Pull request: https://github.com/webkit/webkit/pull/34495

[EWS]

Committed 284551@main (26028203feef): <https://commits.webkit.org/284551@main>

Reviewed commits have been landed. Closing PR #34495 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/137111294>