WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
281717
[Tools][WPE] generate-bundle: fix shipping of inspector.gresource after
284551@main
https://bugs.webkit.org/show_bug.cgi?id=281717
Summary
[Tools][WPE] generate-bundle: fix shipping of inspector.gresource after 28455...
Carlos Alberto Lopez Perez
Reported
2024-10-17 19:43:26 PDT
Since
284269@main
the 'InspectorResource' library no longer exists for WPE so that makes the script generate-bundle fail when it tries to add it to the bundle. See:
https://build.webkit.org/#/builders/1322/builds/2
284551@main
attempted to fix this but it didn't because the script is still trying to copy that library as you can see above Also the new file inspector.gresource file that is copied to the bundle root path doesn't actually work because WPE is unable to find the file at runtime because we are not specifying it. You can check that if you export the env var WEBKIT_INSPECTOR_HTTP_SERVER=127.0.0.1:8186 so the webinspector starts then WPE crashes. So we need to copy this file to a share sub-directory inside the bundle and export the required env var on the wrapper.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2024-10-17 19:46:37 PDT
> Also the new file inspector.gresource file that is copied to the bundle root path doesn't actually work because WPE is unable to find the file at runtime because we are not specifying it.
I mean that we are not exporting the WEBKIT_INSPECTOR_RESOURCES_PATH env var to tell WPE where is the gresource file, so WPE defaults to load it from /usr/local/share/wpe-webkit-2.0/ which is not what we want.
Carlos Alberto Lopez Perez
Comment 2
2024-10-17 19:53:09 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/35403
EWS
Comment 3
2024-10-18 04:22:34 PDT
Committed
285389@main
(316bb9885276): <
https://commits.webkit.org/285389@main
> Reviewed commits have been landed. Closing PR #35403 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug