Bug 280561 – REGRESSION(284269@main) [CMake][WPE] Missing generation of inspector.gresource

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Lauro Moura]

After https://commits.webkit.org/284269@main, I'm getting errors installing WebKit, even after a clean build:

```
CMake Error at Source/WebKit/cmake_install.cmake:59 (file):
  file INSTALL cannot find
  "/home/lauro/wkdev-shared/dev/wk-webdriver/WebKit-WebDriver/WebKitBuild/WPE/Release/WebInspectorUI/DerivedSources/inspector.gresource":
  No such file or directory.
Call Stack (most recent call first):
  Source/cmake_install.cmake:92 (include)
  cmake_install.cmake:47 (include)
FAILED: CMakeFiles/install.util
```

(cmakeargs == "-DENABLE_DEVELOPER_MODE=1 -DENABLE_MINIBROWSER=1 -DENABLE_THUNDER=0 -DENABLE_WEBXR=0 -DENABLE_COG=0 -DENABLE_SPEECH_SYNTHESIS=0 -DENABLE_WEBDRIVER_BIDI=1 -DCMAKE_INSTALL_PREFIX=/home/lauro/opt/wpe-webdriver")

Checking `build.ninja`, there's no mention to the new `inspector.gresource`. After becoming a regular file instead of a library, somehow it was being left out of the dependency tree in my scenario.

What worked for me was the following patch, but I'm not sure if it's the right approach (i.e. the target would go inside the macro instead of where the macro is called).

```
diff --git a/Source/WebKit/PlatformWPE.cmake b/Source/WebKit/PlatformWPE.cmake
index e1d7d2a9e635..d250ced25155 100644
--- a/Source/WebKit/PlatformWPE.cmake
+++ b/Source/WebKit/PlatformWPE.cmake
@@ -536,6 +536,12 @@ endif ()
 
 WEBKIT_BUILD_INSPECTOR_GRESOURCES(${WebInspectorUI_DERIVED_SOURCES_DIR} "inspector.gresource")
 
+# Make sure we add the inspector.gresource target to the WebKit target so it gets built.
+add_custom_target(inspector_gresource_target
+    DEPENDS ${WebInspectorUI_DERIVED_SOURCES_DIR}/inspector.gresource
+)
+add_dependencies(WebKit inspector_gresource_target)
+
 install(FILES ${WebInspectorUI_DERIVED_SOURCES_DIR}/inspector.gresource DESTINATION "${CMAKE_INSTALL_FULL_DATADIR}/wpe-webkit-${WPE_API_VERSION}")
```

[Lauro Moura]

Pull request: https://github.com/WebKit/WebKit/pull/34409

[EWS]

Committed 284443@main (1fe32d327a6c): <https://commits.webkit.org/284443@main>

Reviewed commits have been landed. Closing PR #34409 and removing active labels.