Bug 280125
| Summary: | [CMake] ENABLE_LAYOUT_TESTS should depend on DEVELOPER_MODE | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | CMake | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=202345 | ||
Adrian Perez
When ENABLE_LAYOUT_TESTS is enabled the CMake build compiles WKTR. But WKTR
uses internal functions from Web{Core,Kit}, which are hidden by a linker
script *unless* DEVELOPER_MODE is enabled.
Currently it's possible to set ENABLE_LAYOUT_TESTS=ON with DEVELOPER_MODE=OFF
and the build will fail to link WKTR. It would be better to prevent this set
of config options to work together.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/34118
EWS
Committed 284143@main (a3074bfed0e7): <https://commits.webkit.org/284143@main>
Reviewed commits have been landed. Closing PR #34118 and removing active labels.