Bug 27970

Summary:

bugzilla-tool --commit-queue should only land commit-queue+ patches

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

27918

Bug Blocks:

Attachments:

Description	Flags
Patch v1	eric: review+

Adam Barth

Reported 2009-08-04 00:01:25 PDT

I don't think the land-commit-queue command makes sense. It's more robust to drive the commit-queue from another process. When we do that, we want to only commit patches that have the commit-queue+ flag, so we should make land-patches --commit-queue do the filtering.

Attachments
Patch v1 (4.20 KB, patch) 2009-08-04 00:05 PDT, Adam Barth	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2009-08-04 00:02:25 PDT

This patch requires the infrastructure from Bug 27918.

Adam Barth

Comment 2 2009-08-04 00:05:30 PDT

Created attachment 34039 [details] Patch v1

Eric Seidel (no email)

Comment 3 2009-08-04 00:27:36 PDT

Comment on attachment 34039 [details] Patch v1 Yay minus lines!

Adam Barth

Comment 4 2009-08-04 01:20:07 PDT

Committed revision 46751.

Note You need to log in before you can comment on or make changes to this bug.