Bug 27849 – bugzilla-tool post-commits obsoletes its own work :(

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Working around bug 27847 for now, so I passed a manual list of revisions:

bugzilla-tool post-commits -b 25494 fe5ba4cc272372cbd6c14261081e8d0b856cde87 7a3f6b9a5aabf51fe0d54688805d0fd0e9dc657c 4c929dac07dd08bf2328b755a1054189e158478f
Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml
Obsoleting 6 old patches on bug 25494
Logging in as [e-mail]...
Obsoleting attachment: 29924
Obsoleting attachment: 29926
Obsoleting attachment: 29927
Obsoleting attachment: 30846
Obsoleting attachment: 30847
Obsoleting attachment: 30848
Adding patch "Add more position constructors" to bug 25494

---
 6 files changed, 62 insertions(+), 8 deletions(-)
Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml
Obsoleting 1 old patch on bug 25494
Obsoleting attachment: 33799
Adding patch "Rename positionBeforeNode to positionInParentBeforeNode" to bug 25494

---
 16 files changed, 96 insertions(+), 46 deletions(-)
Fetching: https://bugs.webkit.org/show_bug.cgi?id=25494&ctype=xml
Obsoleting 1 old patch on bug 25494
Obsoleting attachment: 33800
Adding patch "Move them back to Position.h per mjs's request" to bug 25494

---
 7 files changed, 68 insertions(+), 45 deletions(-)


It should have not obsoleted the patches it just posted!

[Eric Seidel (no email)]

I think this is due to the complexity of trying to support posting commits to different bugs...

            if options.obsolete_patches and bug_id not in have_obsoleted_patches:
                PostDiffAsPatchToBug.obsolete_patches_on_bug(bug_id, tool.bugs)
                have_obsoleted_patches.update(bug_id)

is supposed to catch this case, but doesn't seem to be working.

[Eric Seidel (no email)]

Created attachment 33835 [details]
2009-07-30  Mike Fenton  <[e-mail]>

Reviewed by Adam Treat.

Add previously defined out support to PopupMenuQt for marking entries as
disabled and for selecting the desired item.

https://bugs.webkit.org/show_bug.cgi?id=27772

* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 2 files changed, 24 insertions(+), 1 deletions(-)

[Eric Seidel (no email)]

Created attachment 33836 [details]
Simple fix


---
 2 files changed, 12 insertions(+), 1 deletions(-)

[Eric Seidel (no email)]

Created attachment 33837 [details]
Simple fix


---
 2 files changed, 12 insertions(+), 1 deletions(-)

[David Kilzer (:ddkilzer)]

Comment on attachment 33837 [details]
Simple fix

r=me if this fixes the bug.

Why does add() work better than update() here (from a Python language perspective)?

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> Why does add() work better than update() here (from a Python language
> perspective)?

Oh, is updating clearing the contents of the set each time and adding just the new bug_id (instead of adding it to the set)?  That would make sense.

[Eric Seidel (no email)]

in our case 't' is not a set.  I think python is simply silently failing here:

s.update(t)	s |= t	return set s with elements added from t

I think update is doing nothing, where as .add() is doing what we want.

[David Kilzer (:ddkilzer)]

(In reply to comment #7)
> in our case 't' is not a set.  I think python is simply silently failing here:
> 
> s.update(t)    s |= t    return set s with elements added from t
> 
> I think update is doing nothing, where as .add() is doing what we want.

Thanks!  python--

[David Kilzer (:ddkilzer)]

Fixed in r46637.  <http://trac.webkit.org/changeset/46637>

Found Bug 27894 when trying to land this patch.