WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 27894
bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5
https://bugs.webkit.org/show_bug.cgi?id=27894
Summary
bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-...
David Kilzer (:ddkilzer)
Reported
2009-07-31 13:31:05 PDT
$ ./WebKitTools/Scripts/bugzilla-tool land-patches --no-clean --no-build --no-test 27849 Fetching:
https://bugs.webkit.org/show_bug.cgi?id=27849
&ctype=xml Landing 1 patch from 1 bug. Updating working directory Current branch master is up to date. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 101 1215 101 1215 0 0 1578 0 --:--:-- --:--:-- --:--:-- 2525 patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/bugzilla-tool Parsing ChangeLog: WebKitTools/ChangeLog Reading Keychain for bugs.webkit.org account and password. Click "Allow" to continue... Logging in as
ddkilzer@webkit.org
... Clearing review flag on attachment: 33837 Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed
r46637
M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool
r46637
= 20f0cf4533b301428fa09b392316943bedee805a (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46637
Traceback (most recent call last): File "./WebKitTools/Scripts/bugzilla-tool", line 668, in <module> main() File "./WebKitTools/Scripts/bugzilla-tool", line 665, in main return tool.main() File "./WebKitTools/Scripts/bugzilla-tool", line 660, in main return command_object.execute(command_options, command_args, self) File "./WebKitTools/Scripts/bugzilla-tool", line 349, in execute self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool) File "./WebKitTools/Scripts/bugzilla-tool", line 323, in land_patches tool.bugs.clear_attachment_review_flag(patch['id'], comment_text) File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/modules/bugzilla.py", line 366, in clear_attachment_review_flag self.browser['comment'] = comment_text File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 2895, in __setitem__ File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3222, in find_control File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3304, in _find_control ClientForm.AmbiguityError: more than one control matching name 'comment'
Attachments
Patch v1
(1.20 KB, patch)
2009-07-31 13:45 PDT
,
David Kilzer (:ddkilzer)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2009-07-31 13:45:09 PDT
Created
attachment 33901
[details]
Patch v1
Eric Seidel (no email)
Comment 2
2009-07-31 13:50:09 PDT
Comment on
attachment 33901
[details]
Patch v1 LGTM. Are there other places we need to worry about? We have several places we set the comment... r=me to change the rest too.
Eric Seidel (no email)
Comment 3
2009-07-31 13:51:06 PDT
This was actually caused by bugzilla 3.0 iirc. I swear I fixed one of these before. :)
David Kilzer (:ddkilzer)
Comment 4
2009-07-31 13:56:23 PDT
(In reply to
comment #2
)
> (From update of
attachment 33901
[details]
) > LGTM. Are there other places we need to worry about? We have several places > we set the comment... r=me to change the rest too.
These were the only two on the attachments.cgi?action=edit pages that I saw.
Eric Seidel (no email)
Comment 5
2009-07-31 14:00:57 PDT
Comment on
attachment 33901
[details]
Patch v1 I only saw one in your change, but I assume I must have fixed the other one before (or someone did) and forgot to fix this one! eep! :) Thanks again.
David Kilzer (:ddkilzer)
Comment 6
2009-07-31 14:03:53 PDT
$ git svn dcommit Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed
r46640
http://trac.webkit.org/changeset/46640
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug