Bug 277299
| Summary: | WebCore::Timer should assert that web thread lock is held or the web thread is disabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | WebCore Misc. | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ddkilzer, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=168008 https://bugs.webkit.org/show_bug.cgi?id=172390 https://bugs.webkit.org/show_bug.cgi?id=233967 https://bugs.webkit.org/show_bug.cgi?id=185330 |
||
Ryosuke Niwa
WebCore::Timer should assert that the web thread lock is held or the web thread is disabled.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/31423
David Kilzer (:ddkilzer)
See also:
Bug 168008: Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1
<https://bugs.webkit.org/show_bug.cgi?id=168008>
Bug 172390: [iOS]: RunLoop::main().dispatch() needs to take into account USE_WEB_THREAD
<https://bugs.webkit.org/show_bug.cgi?id=172390>
Bug 233967: Add a version of ThreadAssertions that treats UI and Web thread as the same
<https://bugs.webkit.org/show_bug.cgi?id=233967>
David Kilzer (:ddkilzer)
This is basically a dupe of this:
Bug 185330: [iOS] Add assert to catch improper use of WebCore::Timer in UI Process
<https://bugs.webkit.org/show_bug.cgi?id=185330>
EWS
Committed 281614@main (a01578c7c53b): <https://commits.webkit.org/281614@main>
Reviewed commits have been landed. Closing PR #31423 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/132854744>