Bug 271719
| Summary: | Output better metadata for baseline_search_path and expectations_files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
We should include expectations_files in full_results.json, and output the expectations files path alongside the baseline search path (this has caused confusion before, c.f. https://bugs.webkit.org/show_bug.cgi?id=105583#c13), and if we ever want to get rid of the version-specific expectations files (Bug 271331) we need to be outputting this to avoid confusion.
We should also be using some device_type we're actually running, and not None, when calculating the values for full_results.json (we have to choose one, because we have no means to easily segment the data based on device_type without breaking compatibility with every system that consumes these files).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/26476
EWS
Committed 276719@main (aacb258efde8): <https://commits.webkit.org/276719@main>
Reviewed commits have been landed. Closing PR #26476 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/125457720>