Bug 271331
Summary: | Get rid of version-specific TestExpectations files | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ap, ben_schwartz, jbedard, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=105599 |
Sam Sneddon [:gsnedders]
Currently we have:
LayoutTests/platform/mac-monterey-wk1/TestExpectations
LayoutTests/platform/mac-monterey-wk2/TestExpectations
LayoutTests/platform/mac-monterey/TestExpectations
LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations
LayoutTests/platform/mac-ventura-wk1/TestExpectations
LayoutTests/platform/mac-ventura-wk2/TestExpectations
LayoutTests/platform/mac-ventura/TestExpectations
None of these should exist, we should instead have e.g.:
[ Monterey ] fast/dom/SelectorAPI/caseID.html [ Pass Failure ]
in mac-wk1 instead of mac-monterey-wk1.
Potentially:
LayoutTests/platform/gtk4/TestExpectations
should also not exist, but we don't have GTK version as a Test configuration option.
Note that even with these gone in WebKit, we can't redefine the DarwinPort._port_specific_expectations_files without breaking things internal to Apple where there are similar files (including in non-macOS ports) in ApplePort._apple_baseline_path.
See also bug 105599 where we started supporting TestExpectations files in all these directories.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/125106495>