Bug 26842

Summary: Build fix when ENABLE_DATABASE is off
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jmalonzo, mikkel
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
ENABLE_DATABASE build fix eric: review+

Kwang Yul Seo
Reported 2009-06-30 07:52:07 PDT
ScriptObjectQuarantine.cpp won't compile as Database.h is missing when ENABLE_DATABASE is off. Move #include "Database.h" into ENABLE(DATABASE) guard so toggling ENALBE_DATABASE off does not break builds.
Attachments
ENABLE_DATABASE build fix (1.17 KB, patch)
2009-06-30 07:54 PDT, Kwang Yul Seo 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2009-06-30 07:54:31 PDT
Created attachment 32065 [details] ENABLE_DATABASE build fix Build fix.
Eric Seidel (no email)
Comment 2 2009-06-30 14:34:42 PDT
Comment on attachment 32065 [details] ENABLE_DATABASE build fix Looks fine.
Jan Alonzo
Comment 3 2009-06-30 18:35:03 PDT
*** Bug 25113 has been marked as a duplicate of this bug. ***
Jan Alonzo
Comment 4 2009-06-30 18:55:19 PDT
(In reply to comment #1) > Created an attachment (id=32065) [review] > ENABLE_DATABASE build fix > > Build fix. > I think this fix will break the other ports. If you look inside Database.h, the header is also used even if ENABLE_DATABASE is off (there's an else clause). Which port does this happen? If it's the Gtk port, you might want to move Database.h out of the ENABLE_DATABASE guard and put it in webcore_sources further up.
Eric Seidel (no email)
Comment 5 2009-07-01 19:04:26 PDT
r45462
Note You need to log in before you can comment on or make changes to this bug.