Bug 267607
| Summary: | Remove BitmapImage::updateFromSettings() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 265363 | ||
Said Abou-Hallawa
This is an awkward interface to pass some painting options to BitmapImage::draw(). ImagePaintingOptions has been used for this purpose but BitmapImage::updateFromSettings() is used to pass some other options. But in reality all options can be passed through ImagePaintingOptions. With little care things can be restored after removing this method.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/121077174>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/22844
EWS
Committed 273528@main (0c6288be7ffe): <https://commits.webkit.org/273528@main>
Reviewed commits have been landed. Closing PR #22844 and removing active labels.