| Summary: | Combine LocalStorage and SessionStorage into StorageNamespace | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Orlow <jorlow> | ||||||||
| Component: | New Bugs | Assignee: | Jeremy Orlow <jorlow> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, beidson, dglazkov, fishd, michaeln, playmobil, sam, yael, zwarich | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 25376 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jeremy Orlow
2009-06-25 14:32:25 PDT
Created attachment 31891 [details] patch v1 For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376, combine LocalStorage and SessionStorage into StorageNamespace. The synching code (for LocalStorage) has already been removed, so these classes are now very similar. All they do is essentially contain a logical grouping of origins that are attached to specific contexts (be it PageGroups for LocalStorage and Page for SessionStorage). Created attachment 31946 [details]
rebaselined version
No changes, just WebKitTools/Scripts/update-webkit'ed and re-created the patch. Recompiled and did ad-hoc testing to double check we're still good.
Created attachment 31956 [details]
resynced + added #include "DOMWindow.cpp" to storageArea.cpp
resynced + added #include "DOMWindow.cpp" to storageArea.cpp. Recompiled/tested.
landed by Dimitri in 45290 Should this still be marked for review? The bug is closed. |