Bug 265969
| Summary: | Update or Remove tests leveraging historical 'getPropertyCSSValue' | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | gsnedders, karlcow, ntim |
| Priority: | P2 | Keywords: | GoodFirstBug |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=266052 | ||
Ahmad Saleem
Hi Team,
'getPropertyCSSValue' is historical and it cannot be removed without updating 'LayoutTests' relying on it.
So I am creating this bug as potential to merge few of Blink's commits as clean-up to update them and make it easier to remove 'getPropertyCSSValue' eventually.
Blink Commits: https://chromium.googlesource.com/chromium/blink/+/018db695b2fd41eccdf23a87f157611f0425465d , https://chromium.googlesource.com/chromium/blink/+/088bcb0bb1fc92f4144303a6650fcdccaacac5f9 , https://chromium.googlesource.com/chromium/blink/+/16138b933dbebe3e3570464c8e3cf01d530f2bcd , https://chromium.googlesource.com/chromium/blink/+/839bdc83ee530f8b972f4195587995a7bda22368 , https://chromium.googlesource.com/chromium/blink/+/47b9403fd8b928a324d35a71566548ce6592568a , https://chromium.googlesource.com/chromium/blink/+/98d37e56283bb920a7ec652ea9235f8f5fd87a7a ,
https://chromium.googlesource.com/chromium/blink/+/ab1811d8bf4e7fa18f9c6fa44e5a86bb7b2f7d17 ,
https://chromium.googlesource.com/chromium/blink/+/391870c98875dcff621ab992553ebf9f4f695012 ,
https://chromium.googlesource.com/chromium/blink/+/42fab77317a1ba7b9b91225c64460fff932d6312 ,
https://chromium.googlesource.com/chromium/blink/+/d264cf786c1b2a87f99e095e09ea00bb85ee4e69 ,
https://chromium.googlesource.com/chromium/blink/+/2c7a5a8bf7d3f37e0af669bb241886e3aceffbfb ,
https://chromium.googlesource.com/chromium/blink/+/b179bc4d8475adc7943745c6cabe6997202577dc ,
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
WIP PR - https://github.com/WebKit/WebKit/pull/21418
Will add other updates and merges tomorrow.
Ahmad Saleem
PR - https://github.com/WebKit/WebKit/pull/21418
Sam Sneddon [:gsnedders]
*** This bug has been marked as a duplicate of bug 229912 ***
Sam Sneddon [:gsnedders]
oh, sorry, I didn't notice you'd posted a PR here—I'd have done the dance in the opposite direction if I'd noticed!
I hope you don't mind changing the bug mentioned in the commit message!
Ahmad Saleem
(In reply to Sam Sneddon [:gsnedders] from comment #4)
> oh, sorry, I didn't notice you'd posted a PR here—I'd have done the dance in
> the opposite direction if I'd noticed!
>
> I hope you don't mind changing the bug mentioned in the commit message!
Yes - no worries, I will fix. I am not feeling well, so might give it a go later this weekend. I will fix and clean-up more stuff.