Bug 263653
| Summary: | [webkitscmpy] Caller must provide arguments to remote files_changed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 261242 | ||
Jonathan Bedard
For a local repository, it makes sense for 'files_changed' to be an optional argument (because we can assume that if no git ref is provided, the caller means "files changed in the current checkout" as opposed to "files changed in a specific commit". That logic doesn't apply to a remote repository, where we should raise a ValueError if a caller requests files_changed without specifying some sort of git ref.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/117473288>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/19536
EWS
Committed 269765@main (3e615409768a): <https://commits.webkit.org/269765@main>
Reviewed commits have been landed. Closing PR #19536 and removing active labels.