|
Description
Eric Seidel (no email)
2009-06-10 15:53:29 PDT
Test Test Test Success! Foobar! Yay! it worked, trying again... Created attachment 31311 [details]
test file - please ignore review flag
Comment on attachment 31311 [details]
test file - please ignore review flag
Please ignore the review flag on this attachment, I'm using it for testing my script for the moment.
Created attachment 31318 [details]
another test (please ignore review on this test)
Another test for my script. Please ignore the review flag.
Created attachment 31449 [details]
Foobar
---
Created attachment 31450 [details] This matches the default up in WebKit (that was changed in r43318). --- Created attachment 31454 [details] Make Settings::shouldPaintNativeControls default to true Make Settings::shouldPaintNativeControls default to true This matches the default up in WebKit (that was changed in r43318). Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style form controls <https://bugs.webkit.org/show_bug.cgi?id=26493> Reviewed by Darin Adler and Dave Hyatt. No test possible since DRT always uses Mac-style form controls. * page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true. * rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 3 files changed, 26 insertions(+), 1 deletions(-) Created attachment 31455 [details] Make Settings::shouldPaintNativeControls default to true Make Settings::shouldPaintNativeControls default to true This matches the default up in WebKit (that was changed in r43318). Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style form controls <https://bugs.webkit.org/show_bug.cgi?id=26493> Reviewed by Darin Adler and Dave Hyatt. No test possible since DRT always uses Mac-style form controls. * page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true. * rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 3 files changed, 26 insertions(+), 1 deletions(-) Created attachment 31469 [details]
foo
Created attachment 31471 [details] Make Settings::shouldPaintNativeControls default to true Make Settings::shouldPaintNativeControls default to true This matches the default up in WebKit (that was changed in r43318). Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style form controls <https://bugs.webkit.org/show_bug.cgi?id=26493> Reviewed by Darin Adler and Dave Hyatt. No test possible since DRT always uses Mac-style form controls. * page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true. * rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 3 files changed, 26 insertions(+), 1 deletions(-) Created attachment 31472 [details] Update layout test results for addition of datagrid element. Update layout test results for addition of datagrid element. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44784 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 1 files changed, 1 insertions(+), 0 deletions(-) Created attachment 31473 [details] 2009-06-17 David Levin <levin@chromium.org> 2009-06-17 David Levin <levin@chromium.org> Fix chromium Windows build. A mistake that happened during the complicated merge for landing r44775, r44776, r44777. * rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin): (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44783 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 13 insertions(+), 2 deletions(-) Created attachment 31474 [details] 2009-06-17 Eric Carlson <eric.carlson@apple.com> 2009-06-17 Eric Carlson <eric.carlson@apple.com> Reviewed by Simon Fraser. <rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent * rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer. (WebCore::MediaControlInputElement::attachToParent): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44782 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 13 insertions(+), 2 deletions(-) Created attachment 31475 [details] 2009-06-17 Sam Weinig <sam@webkit.org> 2009-06-17 Sam Weinig <sam@webkit.org> Reviewed by Mark Rowe. * security/index.html: Fix some typos. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44781 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 2 files changed, 8 insertions(+), 2 deletions(-) Created attachment 31477 [details] Make Settings::shouldPaintNativeControls default to true Make Settings::shouldPaintNativeControls default to true This matches the default up in WebKit (that was changed in r43318). Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style form controls <https://bugs.webkit.org/show_bug.cgi?id=26493> Reviewed by Darin Adler and Dave Hyatt. No test possible since DRT always uses Mac-style form controls. * page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true. * rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 3 files changed, 26 insertions(+), 1 deletions(-) Created attachment 31478 [details] Update layout test results for addition of datagrid element. Update layout test results for addition of datagrid element. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44784 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 1 files changed, 1 insertions(+), 0 deletions(-) Comment on attachment 31478 [details]
Update layout test results for addition of datagrid element.
Hyatt said he was going to take care of this!
Created attachment 31675 [details]
patch
Created attachment 31874 [details]
patch
Comment on attachment 31874 [details]
patch
Sorry for the review spam.
Created attachment 31887 [details]
patch
Created attachment 31888 [details]
patch
Comment on attachment 31888 [details]
patch
foo
Comment on attachment 31450 [details] This matches the default up in WebKit (that was changed in r43318). Changing the description of this attachment since it violates the maximum length of descriptions in future Bugzilla versions. Here's the previous description: This matches the default up in WebKit (that was changed in r43318). Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style form controls <https://bugs.webkit.org/show_bug.cgi?id=26493> Reviewed by Darin Adler and Dave Hyatt. No test possible since DRT always uses Mac-style form controls. * page/Settings.cpp: Changed the initial value of gShouldPaintNativeControls to true. * rendering/RenderThemeSafari.cpp: (WebCore::RenderTheme::themeForPage): Added a FIXME about the design flaw here involving querying Settings before it's been initialized.git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc Comment on attachment 31888 [details]
patch
Test setting r+ and cq+ from an account w/o review or commit privileges.
Comment on attachment 31888 [details] patch Rejecting patch 31888 from review queue. Eric.C.Seidel@lawrence.edu does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. Comment on attachment 31888 [details]
patch
Testing valid reviewer but invalid cq+
Comment on attachment 31888 [details] patch Rejecting patch 31888 from commit-queue. Eric.C.Seidel@lawrence.edu does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. Comment on attachment 31888 [details]
patch
removing r+ now that testing is complete.
|