Bug 26068

Summary:

V8: Remove usage of v8::Locker in timer callbacks

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

WebCore Misc.

Assignee:

Dmitry Titov <dimich>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, jianli

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	dglazkov: review+

Dmitry Titov

Reported 2009-05-28 14:33:31 PDT

Since we have switched to running 1 worker per worker process, we've been removing the v8 locks from the code to avoid triggering unnecessary api checks. This is one of the v8::Locker usages that's left.

Attachments
Proposed patch (1.41 KB, patch) 2009-05-28 14:40 PDT, Dmitry Titov	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dmitry Titov

Comment 1 2009-05-28 14:40:15 PDT

Created attachment 30749 [details] Proposed patch This completes the fix for bug 25944, since the patches for enabling timers and that bug have "crossed in the queue". Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

Dmitry Titov

Comment 2 2009-05-28 16:45:20 PDT

Landed: http://trac.webkit.org/changeset/44256

Note You need to log in before you can comment on or make changes to this bug.