Bug 258439

Summary: AX: Improve accessibility for tables and table components with display flex, grid, block, inline-block, and contents
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, me, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 239479, 257458    
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2023-06-23 00:00:40 PDT
https://bugs.webkit.org/show_bug.cgi?id=258223 did the hard work of computing table structure based on the DOM rather than the render tree. But even after that patch, tables and table components with assorted display values are often inaccessible to VoiceOver (likely due to parent-child mismatches caused by anonymous table renderers generated when these display values are used).
Attachments
Patch (43.67 KB, patch)
2023-06-23 00:06 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (50.74 KB, patch)
2023-06-23 10:55 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-06-23 00:00:53 PDT
<rdar://problem/111202843>
Tyler Wilcock
Comment 2 2023-06-23 00:06:20 PDT
Created attachment 466808 [details] Patch
chris fleizach
Comment 3 2023-06-23 10:10:03 PDT
Comment on attachment 466808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=466808&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2255 > + if (m_renderer->isAnonymous() && (is<RenderTableRow>(m_renderer) || is<RenderTable>(m_renderer))) should we move this above line 2246, and add the TableCell check there, so all our anonymous check types are together?
Tyler Wilcock
Comment 4 2023-06-23 10:55:47 PDT
Created attachment 466817 [details] Patch
Tyler Wilcock
Comment 5 2023-06-23 11:32:34 PDT
*** Bug 141524 has been marked as a duplicate of this bug. ***
Tyler Wilcock
Comment 6 2023-06-23 11:36:30 PDT
(In reply to chris fleizach from comment #3) > Comment on attachment 466808 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=466808&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2255 > > + if (m_renderer->isAnonymous() && (is<RenderTableRow>(m_renderer) || is<RenderTable>(m_renderer))) > > should we move this above line 2246, and add the TableCell check there, so > all our anonymous check types are together? Fixed!
EWS
Comment 7 2023-06-23 15:40:27 PDT
Committed 265486@main (5da3ca144678): <https://commits.webkit.org/265486@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 466817 [details].
Note You need to log in before you can comment on or make changes to this bug.