Bug 257853
| Summary: | [WPT export friction] Run WPT lint as part of WebKit development via check-webkit-style | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | gsnedders, jbedard, simon.fraser, webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Anne van Kesteren
We should run WPT lint as part of our own listing infrastructure to ensure exports to WPT don't run into issues that would have been easily addressed ahead-of-time.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/110843279>
Jonathan Bedard
Naively, it seems like check-webkit-style would be the right place for this.
Sam Sneddon [:gsnedders]
We currently are meant to blanket ignore everything in LayoutTests (but see Bug 274407), so this also implies changing the current ignore rule to run a specific lint on a bunch of LayoutTests.
Sam Sneddon [:gsnedders]
*** Bug 278503 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
The use-experience here is that if the WPT linter finds an issue when you are exporting a WPT, you have no recourse to fix it and continue the export.
Simon Fraser (smfr)
To run the WPT linter manually, you can pass it full paths to new files:
./LayoutTests/imported/w3c/web-platform-tests/wpt lint <list of absolute paths>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/63010
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/64073
EWS
Committed 312533@main (1c2ce5ed31e5): <https://commits.webkit.org/312533@main>
Reviewed commits have been landed. Closing PR #64073 and removing active labels.