Bug 255442
| Summary: | Page.cpp data: URL style sheet fast path is incorrect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | karlcow, koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 175568 | ||
| Bug Blocks: | |||
Anne van Kesteren
In particular:
* It doesn't use the same base64 decoding options.
* It looks like it's not case-insensitive.
It should probably reuse code from DataURLDecoder.cpp or invoke that directly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
I guess this is about: https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/page/Page.cpp#2181-2209
And to use
https://searchfox.org/wubkat/source/Source/WebCore/platform/network/DataURLDecoder.cpp
Radar WebKit Bug Importer
<rdar://problem/108116260>
Karl Dubost
Anne,
this part is surprising too.
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/platform/network/DataURLDecoder.cpp#93-94
There is
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WTF/wtf/URL.cpp#370-386
used by decode
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebCore/platform/network/DataURLDecoder.cpp#197-203
but which seems to be used only in this case
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp#652-666
The other decode is used at two places
https://searchfox.org/wubkat/source/Source/WebCore/loader/ResourceLoader.cpp#297
https://searchfox.org/wubkat/source/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp#343
And there is also
https://searchfox.org/wubkat/rev/82caf34be7c823fc4fddd90cc167a6315bffebfd/Source/WTF/wtf/URL.cpp#1083-1101