Bug 254973

Summary:	Remove Quirk needsToForceUserSelectAndUserDragWhenInstallingImageOverlay on YouTube.com and google.com
Product:	WebKit	Reporter:	Karl Dubost <karlcow>
Component:	Platform	Assignee:	Karl Dubost <karlcow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
URL:	http://youtube.com/
Bug Depends on:	233670
Bug Blocks:

Karl Dubost

Reported 2023-04-03 23:02:18 PDT

Steps to reproduce 1. Navigate to a YouTube video. 2. Hover over related video thumbnails that have recognizable text. 3. Drag to select the text. Ex At some point, (3) wouldn't work and you would end up not selecting text. from Bug 233670 > That said, I just tried this out on YouTube with site-specific hacks disabled, and it now appears to work. Perhaps we don't need this quirk anymore.. This has been tested by Zohreh Momeni and Wenson Hsieh https://github.com/WebKit/WebKit/blob/e947c7c9fe38b1d388608b24ed2c753ba25fbd76/Source/WebCore/page/Quirks.cpp#L1405-L1424

Attachments
Add attachment proposed patch, testcase, etc.

Note You need to log in before you can comment on or make changes to this bug.

Karl Dubost

Comment 1 2023-04-03 23:03:10 PDT

rdar://107576605

Karl Dubost

Comment 2 2023-04-09 22:23:33 PDT

This is also not necessary anymore for rdar://76500331 which is the same type of failure on Google search. We will remove both in the same Commit.

Karl Dubost

Comment 3 2023-04-09 22:32:16 PDT

Pull request: https://github.com/WebKit/WebKit/pull/12561

EWS

Comment 4 2023-04-13 00:24:29 PDT

Committed 262907@main (2dd8ae90d505): <https://commits.webkit.org/262907@main> Reviewed commits have been landed. Closing PR #12561 and removing active labels.