Bug 252367

Summary: [Win] The generic URL::fileSystemPath has to remove a leading slash
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web Template FrameworkAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, don.olmstead, ews-watchlist, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175336    
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2023-02-15 17:32:10 PST
REGRESSION(260269@main) [Win] URL::fileSystemPath has to remove a leading slash Regressions: Unexpected timeouts (7) fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html [ Timeout ] fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html [ Timeout ] js/weakref-finalizationregistry.html [ Timeout ] storage/domstorage/localstorage/blocked-file-access-permitted-by-quirk.html [ Timeout ] storage/domstorage/localstorage/blocked-file-access.html [ Timeout ] storage/domstorage/localstorage/file-can-access.html [ Timeout ] storage/domstorage/sessionstorage/blocked-file-access.html [ Timeout ] Regressions: Unexpected text-only failures (6) fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html [ Failure ] fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html [ Failure ] fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html [ Failure ] fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html [ Failure ] fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html [ Failure ] fast/dom/HTMLAnchorElement/anchor-file-blob-download.html [ Failure ]
Attachments
Patch (1018 bytes, patch)
2023-02-15 17:38 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2023-02-15 17:38:47 PST
Created attachment 465014 [details] Patch
Darin Adler
Comment 2 2023-02-16 00:01:08 PST
Comment on attachment 465014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=465014&action=review > COMMIT_MESSAGE:1 > +REGRESSION(260269@main) [Win] URL::fileSystemPath has to remove a leading slash Why does Windows need to do this? Why does no other platform need to do this?
Fujii Hironori
Comment 3 2023-02-16 11:50:38 PST
Comment on attachment 465014 [details] Patch Good point. I should explain it in the commit log. Thank you. I was feeling pressed. 260355@main reverted the change. I will revise the patch.
Fujii Hironori
Comment 4 2023-02-21 20:13:29 PST
Pull request: https://github.com/WebKit/WebKit/pull/10492
Darin Adler
Comment 5 2023-02-22 08:59:19 PST
Now that the Apple Windows port is not supported, is any Windows port still using Core Foundation?
Fujii Hironori
Comment 6 2023-02-22 11:49:39 PST
WinCairo is using CFLite and enabling USE_CF. bug#22527 https://sourceforge.net/projects/opencflite/
Radar WebKit Bug Importer
Comment 7 2023-02-22 17:33:21 PST
<rdar://problem/105808089>
EWS
Comment 8 2023-02-23 03:40:05 PST
Committed 260739@main (5e1c8e09258c): <https://commits.webkit.org/260739@main> Reviewed commits have been landed. Closing PR #10492 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.