Bug 252367 – [Win] The generic URL::fileSystemPath has to remove a leading slash

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Fujii Hironori]

REGRESSION(260269@main) [Win] URL::fileSystemPath has to remove a leading slash

Regressions: Unexpected timeouts (7)
  fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html [ Timeout ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html [ Timeout ]
  js/weakref-finalizationregistry.html [ Timeout ]
  storage/domstorage/localstorage/blocked-file-access-permitted-by-quirk.html [ Timeout ]
  storage/domstorage/localstorage/blocked-file-access.html [ Timeout ]
  storage/domstorage/localstorage/file-can-access.html [ Timeout ]
  storage/domstorage/sessionstorage/blocked-file-access.html [ Timeout ]

Regressions: Unexpected text-only failures (6)
  fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html [ Failure ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html [ Failure ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html [ Failure ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html [ Failure ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html [ Failure ]
  fast/dom/HTMLAnchorElement/anchor-file-blob-download.html [ Failure ]

[Fujii Hironori]

Created attachment 465014 [details]
Patch

[Darin Adler]

Comment on attachment 465014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465014&action=review

> COMMIT_MESSAGE:1
> +REGRESSION(260269@main) [Win] URL::fileSystemPath has to remove a leading slash 

Why does Windows need to do this?

Why does no other platform need to do this?

[Fujii Hironori]

Comment on attachment 465014 [details]
Patch

Good point. I should explain it in the commit log. Thank you.
I was feeling pressed. 260355@main reverted the change. I will revise the patch.

[Fujii Hironori]

Pull request: https://github.com/WebKit/WebKit/pull/10492

[Darin Adler]

Now that the Apple Windows port is not supported, is any Windows port still using Core Foundation?

[Fujii Hironori]

WinCairo is using CFLite and enabling USE_CF.
bug#22527
https://sourceforge.net/projects/opencflite/

[Radar WebKit Bug Importer]

<rdar://problem/105808089>

[EWS]

Committed 260739@main (5e1c8e09258c): <https://commits.webkit.org/260739@main>

Reviewed commits have been landed. Closing PR #10492 and removing active labels.