Bug 22527 – Remove Windows Cairo Build Dependencies on Non-Redistributable Libraries

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

The current Windows Cairo build depends on several proprietary Apple libraries.  This patch removes these libraries from the link commands for the Debug_Cairo and Release_Cairo targets.

The patch assumes that the user has placed the necessary replacement libraries in the appropriate directories in the WebKit build environment.

Interested parties can obtain a full set of dependencies (Cairo, cURL, and CFLite) from http://idisk.mac.com/bfulgham-Public/requirements.zip

[Brent Fulgham]

Created attachment 25553 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link

Patch to Visual Studio project so that the Cairo build does not link against CoreFoundation.dll, CoreGraphics.dll, CFnetwork.dll, or the QuickTime dll.

[Alexey Proskuryakov]

Comment on attachment 25553 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link

r=me, but I think that some include paths could be also removed from both WebKit.vcproj and WebCore.vcproj for consistency.

[Brent Fulgham]

I'm generating a new patch which removes the QuickTime header path.  The remaining CF stuff is still used, as I am now using CFLite, and may (soon) be using CFNetwork APSL version.

[Brent Fulgham]

Created attachment 25560 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link	

Revised to do the following:
1.  Removes non-redistributable include paths (generaly, just QuickTime) from the WebCore project.  No longer attempts to build the QuickTime video handling objects.
2.  No longer builds the QuickTime library for Cairo_Release/Cairo_Debug
3.  Removes linking commands for non-redistributable libraries from WebKit.dll

[Brent Fulgham]

(In reply to comment #4)
Completed build of regular Windows (CG) and confirmed this change does not prevent normal function of features in standard Windows build.

[Alexey Proskuryakov]

Comment on attachment 25560 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link	

r=me, but please add WebKit.sln to ChangeLog.

[Brent Fulgham]

Created attachment 25598 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link	

Include WebKit.sln change in the ChangeLog

[Alexey Proskuryakov]

Comment on attachment 25598 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link	

r=me

[Matt Lilek]

Committed revision 38847.