Bug 25113

Summary: [GTK] Turning off sqlite don't work in ScriptObjectQuarantine
Product: WebKit Reporter: Mikkel Kruse Johnsen <mikkel>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: fujii.hironori, jmalonzo, mikkel
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix disabling off sqlite
none
Fix disabling off sqlite (1.1.5)
none
Fix disabling off sqlite (1.1.5), with ChangeLog
jmalonzo: review-
Disabling of database
none
Move Database.h inside check none

Description Mikkel Kruse Johnsen 2009-04-09 04:32:49 PDT
Patch to fix it.
Comment 1 Mikkel Kruse Johnsen 2009-04-09 04:33:25 PDT
Created attachment 29364 [details]
Fix disabling off sqlite
Comment 2 Jan Alonzo 2009-04-19 02:46:17 PDT
(In reply to comment #1)
> Created an attachment (id=29364) [review]
> Fix disabling off sqlite
> 

This patch requires a ChangeLog. And also you might want to set the review flag to '?' once you've updated the patch.
Comment 3 Mikkel Kruse Johnsen 2009-04-19 06:46:37 PDT
Created attachment 29605 [details]
Fix disabling off sqlite (1.1.5)
Comment 4 Mikkel Kruse Johnsen 2009-04-19 06:54:37 PDT
Created attachment 29606 [details]
Fix disabling off sqlite (1.1.5), with ChangeLog
Comment 5 Jan Alonzo 2009-05-15 06:55:42 PDT
Comment on attachment 29606 [details]
Fix disabling off sqlite (1.1.5), with ChangeLog

An almost similar patch was landed in r42709 - http://trac.webkit.org/changeset/42709.

r- because of this.
Comment 6 Jan Alonzo 2009-05-15 06:56:32 PDT
Please confirm if this is still an issue.

Thanks.
Comment 7 Mikkel Kruse Johnsen 2009-05-16 05:49:41 PDT
This is not fixed completly, one header is still not checked.

See patch.
Comment 8 Mikkel Kruse Johnsen 2009-05-16 05:50:22 PDT
Created attachment 30413 [details]
Disabling of database
Comment 9 Jan Alonzo 2009-06-06 19:47:43 PDT
(In reply to comment #8)
> Created an attachment (id=30413) [review]
> Disabling of database
> 

Hi Mikkel. Thanks. Your patch needs a ChangeLog. Please see http://webkit.org/coding/contributing.html for more info.
Comment 10 Mikkel Kruse Johnsen 2009-06-21 04:40:50 PDT
Created attachment 31611 [details]
Move Database.h inside check

Here is the patch with ChangeLog included.
Comment 11 Jan Alonzo 2009-06-24 06:52:21 PDT
*** Bug 26678 has been marked as a duplicate of this bug. ***
Comment 12 Jan Alonzo 2009-06-30 18:35:03 PDT

*** This bug has been marked as a duplicate of 26842 ***