Bug 25113

Summary:

[GTK] Turning off sqlite don't work in ScriptObjectQuarantine

Product:

WebKit

Reporter:

Mikkel Kruse Johnsen <mikkel>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

fujii.hironori, jmalonzo, mikkel

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Fix disabling off sqlite	none
Fix disabling off sqlite (1.1.5)	none
Fix disabling off sqlite (1.1.5), with ChangeLog	jmalonzo: review-
Disabling of database	none
Move Database.h inside check	none

Mikkel Kruse Johnsen

Reported 2009-04-09 04:32:49 PDT

Patch to fix it.

Attachments
Fix disabling off sqlite (1.85 KB, patch) 2009-04-09 04:33 PDT, Mikkel Kruse Johnsen	no flags	Details Formatted Diff Diff
Fix disabling off sqlite (1.1.5) (2.11 KB, patch) 2009-04-19 06:46 PDT, Mikkel Kruse Johnsen	no flags	Details Formatted Diff Diff
Fix disabling off sqlite (1.1.5), with ChangeLog (2.66 KB, patch) 2009-04-19 06:54 PDT, Mikkel Kruse Johnsen	jmalonzo: review-	Details Formatted Diff Diff
Disabling of database (668 bytes, patch) 2009-05-16 05:50 PDT, Mikkel Kruse Johnsen	no flags	Details Formatted Diff Diff
Move Database.h inside check (1.31 KB, patch) 2009-06-21 04:40 PDT, Mikkel Kruse Johnsen	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mikkel Kruse Johnsen

Comment 1 2009-04-09 04:33:25 PDT

Created attachment 29364 [details] Fix disabling off sqlite

Jan Alonzo

Comment 2 2009-04-19 02:46:17 PDT

(In reply to comment #1) > Created an attachment (id=29364) [review] > Fix disabling off sqlite > This patch requires a ChangeLog. And also you might want to set the review flag to '?' once you've updated the patch.

Mikkel Kruse Johnsen

Comment 3 2009-04-19 06:46:37 PDT

Created attachment 29605 [details] Fix disabling off sqlite (1.1.5)

Mikkel Kruse Johnsen

Comment 4 2009-04-19 06:54:37 PDT

Created attachment 29606 [details] Fix disabling off sqlite (1.1.5), with ChangeLog

Jan Alonzo

Comment 5 2009-05-15 06:55:42 PDT

Comment on attachment 29606 [details] Fix disabling off sqlite (1.1.5), with ChangeLog An almost similar patch was landed in r42709 - http://trac.webkit.org/changeset/42709. r- because of this.

Jan Alonzo

Comment 6 2009-05-15 06:56:32 PDT

Please confirm if this is still an issue. Thanks.

Mikkel Kruse Johnsen

Comment 7 2009-05-16 05:49:41 PDT

This is not fixed completly, one header is still not checked. See patch.

Mikkel Kruse Johnsen

Comment 8 2009-05-16 05:50:22 PDT

Created attachment 30413 [details] Disabling of database

Jan Alonzo

Comment 9 2009-06-06 19:47:43 PDT

(In reply to comment #8) > Created an attachment (id=30413) [review] > Disabling of database > Hi Mikkel. Thanks. Your patch needs a ChangeLog. Please see http://webkit.org/coding/contributing.html for more info.

Mikkel Kruse Johnsen

Comment 10 2009-06-21 04:40:50 PDT

Created attachment 31611 [details] Move Database.h inside check Here is the patch with ChangeLog included.

Jan Alonzo

Comment 11 2009-06-24 06:52:21 PDT

*** Bug 26678 has been marked as a duplicate of this bug. ***

Jan Alonzo

Comment 12 2009-06-30 18:35:03 PDT

*** This bug has been marked as a duplicate of 26842 ***

Note You need to log in before you can comment on or make changes to this bug.