Bug 247364
| Summary: | Remove CSSKeyframesRule.insertRule() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | CSS | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, karlcow, ntim, rbuis, sabouhallawa, simon.fraser, thorton, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=57910 | ||
Ahmad Saleem
Hi Team,
I couldn't find bug so I am creating this to alias "insertRule" as "append" or remove since it was removed in Blink (2015) and was never supported by Gecko & Internet Explorer 11.
Web-Spec - https://drafts.csswg.org/css-animations/#interface-csskeyframesrule
Blink commit for aliasing - https://src.chromium.org/viewvc/blink?view=revision&revision=194122
Blink commit for removing - https://src.chromium.org/viewvc/blink?view=revision&revision=195797
Current IDL file - https://github.com/WebKit/WebKit/blob/1a4522de8a5d226a336c85237dd15144174fadfc/Source/WebCore/css/CSSKeyframesRule.idl#L35
It shows that we still support this.
Just wanted to create a bug for future purposes to remove this and align with Web-Specs.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
We intentionally kept it in bug 57910, but perhaps it's less relevant now. Could be difficult to confirm.
Karl Dubost
Intent to Remove for Blink in 2015
https://groups.google.com/a/chromium.org/g/blink-dev/c/wW7w8Hro78s/m/JDULF2oM9iIJ
Changed in Gecko in 2013
https://bugzilla.mozilla.org/show_bug.cgi?id=841896
Karl Dubost
Also has a finger in the wind evaluation.
https://cs.github.com/?scopeName=All+repos&scope=&q=CSSKeyframesRule.insertRule+language%3AJavaScript
0 match on GitHub code.
Radar WebKit Bug Importer
<rdar://problem/102141002>
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/8084
EWS
Committed 258361@main (c26a65e62e39): <https://commits.webkit.org/258361@main>
Reviewed commits have been landed. Closing PR #8084 and removing active labels.