Bug 24492

Summary: Move Local and NoAccess security rules from FrameLoader to SecurityOrigin
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: Page LoadingAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jianli, jorlow, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 25040    
Attachments:
Description Flags
patchy fishd: review+

Darin Fisher (:fishd, Google)
Reported 2009-03-10 09:28:14 PDT
Move Local and NoAccess security rules from FrameLoader to SecurityOrigin This bug is about moving the following functions: registerURLSchemeAsLocal shouldTreatURLAsLocal shouldTreatURLSchemeAsLocal registerURLSchemeAsNoAccess shouldTreatURLSchemeAsNoAccess I also question whether we should keep shouldTreatURLAsLocal. It seems a bit unnecessary.
Attachments
patchy (16.25 KB, patch)
2009-06-13 21:02 PDT, Adam Barth 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-03-10 09:28:49 PDT
There is some related discussion in bug 24437.
Jian Li
Comment 2 2009-04-03 15:13:54 PDT
We also need to make SecurityOrigin thread safe. Considering making all statics use TLS.
Darin Fisher (:fishd, Google)
Comment 3 2009-04-03 15:22:26 PDT
I think that should be turned into a separate bug. This one is just above moving some code, which is what I plan to do.
Jeremy Orlow
Comment 4 2009-06-03 13:52:40 PDT
Hm. Interesting. This seems a bit related to https://bugs.webkit.org/show_bug.cgi?id=26143 ("SecurityOrigin should probably be split into Origin and EffectiveScriptOrigin").
Adam Barth
Comment 5 2009-06-13 20:30:59 PDT
Stealing. This is low hanging fruit on my quest to tame FrameLoader.
Adam Barth
Comment 6 2009-06-13 21:02:17 PDT
Created attachment 31251 [details] patchy
Darin Fisher (:fishd, Google)
Comment 7 2009-06-13 21:06:53 PDT
Comment on attachment 31251 [details] patchy > +2009-06-13 Adam Barth <abarth@webkit.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from > + FrameLoader to SecurityOrigin. > + nit: provide a bug reference. same goes for the other ChangeLogs. R=me
Adam Barth
Comment 8 2009-06-13 21:08:27 PDT
> nit: provide a bug reference. same goes for the other ChangeLogs. Thanks. I have trouble remembering to do that for some reason.
Adam Barth
Comment 9 2009-06-13 21:37:37 PDT
Fixed in http://trac.webkit.org/changeset/44664.
Note You need to log in before you can comment on or make changes to this bug.