Bug 244103
Summary: | [Cocoa] Some AVIF images can't be rendered because their containers formats are HEIF | ||
---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> |
Component: | Images | Assignee: | Said Abou-Hallawa <sabouhallawa> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | oliver, sabouhallawa, tetsuharu.ohzeki, thierry.koblentz, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=241904 https://bugs.webkit.org/show_bug.cgi?id=245097 |
Myles C. Maxfield
From https://bugs.webkit.org/show_bug.cgi?id=241904#c4
> I find some avif image in base64 format still can't be render in Safari 16.Here is the image src link https://github.com/kamalendugarai/webp-avif-browsers-support-detection/blob/master/src/index.js#L11
> Browser version 18614.1.19.1.5
> This happened in both Mac OS 13 and iOS 16.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98850829>
Myles C. Maxfield
Looks like this is a bug in a system framework. Tracking in <rdar://problem/98850829>
Said Abou-Hallawa
*** Bug 244324 has been marked as a duplicate of this bug. ***
Said Abou-Hallawa
I think we can fix it (for now) by looking at the ftyp box of the HEIF/AVIF files and check the major_brand and the compatible_brands in this box.
HEIF/AVIF files start with an ftyp box
aligned(8) class GeneralTypeBox(code) extends Box(code) {
unsigned int(32) major_brand;
unsigned int(32) minor_version;
unsigned int(32) compatible_brands[]; // to end of the box
}
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/4434
EWS
Committed 254591@main (08227904ddb6): <https://commits.webkit.org/254591@main>
Reviewed commits have been landed. Closing PR #4434 and removing active labels.
Said Abou-Hallawa
*** Bug 245097 has been marked as a duplicate of this bug. ***
Thierry
I'm looking at https://tabpanelwidget.com in Safari Version 17.6 (19618.3.11.11.5) and all these AVIF images show blank:
https://tabpanelwidget.com/hero-home-page.1afc539c.avif
https://tabpanelwidget.com/hero-home-page@2x.148d84a6.avif
https://tabpanelwidget.com/hero-home-page@3x.1920d4b3.avif
Alexey Proskuryakov
Thank you for bringing this up. This is a different issue, as these images are not HEIF in disguise. Please file a new bug report. Since these issues are typically in underlying system frameworks, it's best to file it at https://feedbackassistant.apple.com for Apple engineers to investigate, and to post the FB number here for tracking.
Thierry
FB Number: 16194197
https://feedbackassistant.apple.com/feedback/16194197