Bug 24370 – padding on textareas should go inside the scrollbar

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Ojan Vafai]

This is how padding works on every other element and it's what IE does. It's not what Gecko does, but they are just wrong here.

Patch coming soon.

[Ojan Vafai]

Created attachment 28375 [details]
Layout tests for various types of textareas in quirks and standards modes.

 LayoutTests/fast/forms/basic-textareas-quirks.html |  252 +++++++
 LayoutTests/fast/forms/basic-textareas.html        |  252 +++++++
 .../fast/forms/basic-textareas-expected.checksum   |    1 +
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 0 -> 116054 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    |  654 ++++++++++++++++++
 .../forms/basic-textareas-quirks-expected.checksum |    1 +
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 0 -> 115289 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt |  712 ++++++++++++++++++++
 8 files changed, 1872 insertions(+), 0 deletions(-)

[Ojan Vafai]

Created attachment 28376 [details]
Put the padding inside scrollbars on textareas.

 WebCore/css/CSSStyleSelector.cpp                  |    6 ++
 WebCore/rendering/RenderTextControl.cpp           |   61 +--------------------
 WebCore/rendering/RenderTextControl.h             |   10 ----
 WebCore/rendering/RenderTextControlMultiLine.cpp  |   40 +++-----------
 WebCore/rendering/RenderTextControlMultiLine.h    |    1 -
 WebCore/rendering/RenderTextControlSingleLine.cpp |   57 +++++++++++++++++++
 WebCore/rendering/RenderTextControlSingleLine.h   |   11 ++++
 WebCore/rendering/TextControlInnerElements.cpp    |   29 +++++++++-
 8 files changed, 111 insertions(+), 104 deletions(-)

[Ojan Vafai]

These are ready for review. I need to rebaseline some tests, but I've confirmed that the new output is correct. Will send a new patch with test rebaselines soon. The first patch with the LayoutTest was baselined with a clean tree so that it will be clear what's changing from the second patch.

[Ojan Vafai]

Created attachment 28378 [details]
LayoutTest rebaselines after moving padding inside scrollbars on textareas.

 .../mac/editing/inserting/4960120-1-expected.txt   |   14 +-
 .../nested-blocks-with-text-area-expected.txt      |   10 +-
 .../editing/pasteboard/pasting-tabs-expected.txt   |   10 +-
 .../fast/block/margin-collapse/103-expected.txt    |   30 +-
 .../fast/css/resize-corner-tracking-expected.txt   |   12 +-
 .../reset-textarea-expected.txt                    |   16 +-
 .../platform/mac/fast/dynamic/008-expected.txt     |   10 +-
 .../fast/forms/basic-textareas-expected.checksum   |    2 +-
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 116054 -> 116253 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    |  844 +++++++++---------
 .../forms/basic-textareas-quirks-expected.checksum |    2 +-
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 115289 -> 115468 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt |  960 ++++++++++----------
 .../fast/forms/form-element-geometry-expected.txt  |   20 +-
 .../mac/fast/forms/negativeLineHeight-expected.txt |   12 +-
 .../mac/fast/forms/textAreaLineHeight-expected.txt |   40 +-
 .../mac/fast/forms/textarea-align-expected.txt     |   50 +-
 .../mac/fast/forms/textarea-rows-cols-expected.txt |  182 ++--
 .../fast/forms/textarea-scroll-height-expected.txt |   88 +-
 .../mac/fast/forms/textarea-scrollbar-expected.txt |   60 +-
 .../fast/forms/textarea-scrolled-type-expected.txt |   90 +-
 .../fast/forms/textarea-setinnerhtml-expected.txt  |   10 +-
 .../mac/fast/forms/textarea-width-expected.txt     |   16 +-
 .../mac/fast/overflow/overflow-x-y-expected.txt    |   18 +-
 .../fast/parser/comment-in-textarea-expected.txt   |   20 +-
 .../parser/entity-comment-in-textarea-expected.txt |   10 +-
 .../parser/open-comment-in-textarea-expected.txt   |   20 +-
 .../replaced/width100percent-textarea-expected.txt |   84 +-
 .../platform/mac/fast/table/003-expected.txt       |    6 +-
 .../rtl-white-space-pre-wrap-expected.txt          |   14 +-
 .../tests/navigation/anchor-basic-expected.txt     |   14 +-
 .../tests/navigation/anchor-frames-expected.txt    |   14 +-
 .../tests/navigation/anchor-goback-expected.txt    |   14 +-
 .../navigation/anchor-subframeload-expected.txt    |   14 +-
 .../navigation/javascriptlink-basic-expected.txt   |   14 +-
 .../navigation/javascriptlink-frames-expected.txt  |   14 +-
 .../navigation/javascriptlink-goback-expected.txt  |   14 +-
 .../javascriptlink-subframeload-expected.txt       |   14 +-
 .../navigation/metaredirect-basic-expected.txt     |   14 +-
 .../navigation/metaredirect-frames-expected.txt    |   14 +-
 .../navigation/metaredirect-goback-expected.txt    |   14 +-
 .../metaredirect-subframeload-expected.txt         |   14 +-
 .../tests/navigation/post-goback2-expected.txt     |   14 +-
 .../navigation/postredirect-goback2-expected.txt   |   14 +-
 .../navigation/redirect302-basic-expected.txt      |   14 +-
 .../navigation/redirect302-frames-expected.txt     |   14 +-
 .../navigation/redirect302-goback-expected.txt     |   14 +-
 .../redirect302-subframeload-expected.txt          |   14 +-
 .../navigation/relativeanchor-basic-expected.txt   |   14 +-
 .../navigation/relativeanchor-frames-expected.txt  |   14 +-
 .../navigation/relativeanchor-goback-expected.txt  |   14 +-
 .../navigation/slowmetaredirect-basic-expected.txt |   14 +-
 .../slowtimerredirect-basic-expected.txt           |   14 +-
 .../tests/navigation/success200-basic-expected.txt |   14 +-
 .../navigation/success200-frames-expected.txt      |   14 +-
 .../success200-frames-loadsame-expected.txt        |   14 +-
 .../navigation/success200-goback-expected.txt      |   14 +-
 .../navigation/success200-loadsame-expected.txt    |   14 +-
 .../navigation/success200-reload-expected.txt      |   14 +-
 .../success200-subframeload-expected.txt           |   14 +-
 .../navigation/timerredirect-basic-expected.txt    |   14 +-
 .../navigation/timerredirect-frames-expected.txt   |   14 +-
 .../navigation/timerredirect-goback-expected.txt   |   14 +-
 .../timerredirect-subframeload-expected.txt        |   14 +-
 .../mac/tables/mozilla/bugs/bug194024-expected.txt |   90 +-
 .../mac/tables/mozilla/bugs/bug30559-expected.txt  |   10 +-
 .../mac/tables/mozilla/bugs/bug30692-expected.txt  |   20 +-
 67 files changed, 1618 insertions(+), 1628 deletions(-)

[Ojan Vafai]

Created attachment 28447 [details]
Put the padding inside scrollbars on textareas.

 WebCore/css/CSSStyleSelector.cpp                  |    6 ++
 WebCore/rendering/RenderTextControl.cpp           |   61 +--------------------
 WebCore/rendering/RenderTextControl.h             |   10 ----
 WebCore/rendering/RenderTextControlMultiLine.cpp  |   40 +++-----------
 WebCore/rendering/RenderTextControlMultiLine.h    |    1 -
 WebCore/rendering/RenderTextControlSingleLine.cpp |   57 +++++++++++++++++++
 WebCore/rendering/RenderTextControlSingleLine.h   |   11 ++++
 WebCore/rendering/TextControlInnerElements.cpp    |   30 ++++++++++-
 8 files changed, 112 insertions(+), 104 deletions(-)

[Ojan Vafai]

Comment on attachment 28376 [details]
Put the padding inside scrollbars on textareas.

Obsoleted by new patch which fixes build error from syncing to trunk.

[Ojan Vafai]

Created attachment 28567 [details]
LayoutTest rebaselines after moving padding inside scrollbars on textareas.

 .../mac/editing/inserting/4960120-1-expected.txt   |   14 +-
 .../nested-blocks-with-text-area-expected.txt      |   10 +-
 .../editing/pasteboard/pasting-tabs-expected.txt   |   10 +-
 .../fast/block/margin-collapse/103-expected.txt    |   30 +-
 .../fast/css/resize-corner-tracking-expected.txt   |   12 +-
 .../reset-textarea-expected.txt                    |   16 +-
 .../platform/mac/fast/dynamic/008-expected.txt     |   10 +-
 .../fast/forms/basic-textareas-expected.checksum   |    2 +-
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 116054 -> 116253 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    |  963 ++++++++++--------
 .../forms/basic-textareas-quirks-expected.checksum |    2 +-
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 115289 -> 115468 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt | 1074 +++++++++++---------
 .../fast/forms/form-element-geometry-expected.txt  |   20 +-
 .../mac/fast/forms/negativeLineHeight-expected.txt |   14 +-
 .../mac/fast/forms/textAreaLineHeight-expected.txt |   48 +-
 .../mac/fast/forms/textarea-align-expected.txt     |   50 +-
 .../mac/fast/forms/textarea-rows-cols-expected.txt |  204 ++--
 .../fast/forms/textarea-scroll-height-expected.txt |   88 +-
 .../mac/fast/forms/textarea-scrollbar-expected.txt |   60 +-
 .../fast/forms/textarea-scrolled-type-expected.txt |   90 +-
 .../fast/forms/textarea-setinnerhtml-expected.txt  |   10 +-
 .../mac/fast/forms/textarea-width-expected.txt     |   16 +-
 .../mac/fast/overflow/overflow-x-y-expected.txt    |   18 +-
 .../fast/parser/comment-in-textarea-expected.txt   |   22 +-
 .../parser/entity-comment-in-textarea-expected.txt |   12 +-
 .../parser/open-comment-in-textarea-expected.txt   |   22 +-
 .../replaced/width100percent-textarea-expected.txt |   84 +-
 .../platform/mac/fast/table/003-expected.txt       |    6 +-
 .../rtl-white-space-pre-wrap-expected.txt          |   14 +-
 .../tests/navigation/anchor-basic-expected.txt     |   14 +-
 .../tests/navigation/anchor-frames-expected.txt    |   14 +-
 .../tests/navigation/anchor-goback-expected.txt    |   18 +-
 .../navigation/anchor-subframeload-expected.txt    |   14 +-
 .../navigation/javascriptlink-basic-expected.txt   |   14 +-
 .../navigation/javascriptlink-frames-expected.txt  |   14 +-
 .../navigation/javascriptlink-goback-expected.txt  |   18 +-
 .../javascriptlink-subframeload-expected.txt       |   14 +-
 .../navigation/metaredirect-basic-expected.txt     |   14 +-
 .../navigation/metaredirect-frames-expected.txt    |   14 +-
 .../navigation/metaredirect-goback-expected.txt    |   18 +-
 .../metaredirect-subframeload-expected.txt         |   14 +-
 .../tests/navigation/post-goback2-expected.txt     |   18 +-
 .../navigation/postredirect-goback2-expected.txt   |   18 +-
 .../navigation/redirect302-basic-expected.txt      |   14 +-
 .../navigation/redirect302-frames-expected.txt     |   14 +-
 .../navigation/redirect302-goback-expected.txt     |   18 +-
 .../redirect302-subframeload-expected.txt          |   14 +-
 .../navigation/relativeanchor-basic-expected.txt   |   14 +-
 .../navigation/relativeanchor-frames-expected.txt  |   14 +-
 .../navigation/relativeanchor-goback-expected.txt  |   14 +-
 .../navigation/slowmetaredirect-basic-expected.txt |   14 +-
 .../slowtimerredirect-basic-expected.txt           |   14 +-
 .../tests/navigation/success200-basic-expected.txt |   14 +-
 .../navigation/success200-frames-expected.txt      |   14 +-
 .../success200-frames-loadsame-expected.txt        |   14 +-
 .../navigation/success200-goback-expected.txt      |   18 +-
 .../navigation/success200-loadsame-expected.txt    |   14 +-
 .../navigation/success200-reload-expected.txt      |   14 +-
 .../success200-subframeload-expected.txt           |   14 +-
 .../navigation/timerredirect-basic-expected.txt    |   14 +-
 .../navigation/timerredirect-frames-expected.txt   |   14 +-
 .../navigation/timerredirect-goback-expected.txt   |   18 +-
 .../timerredirect-subframeload-expected.txt        |   14 +-
 .../mac/tables/mozilla/bugs/bug194024-expected.txt |   90 +-
 .../mac/tables/mozilla/bugs/bug30559-expected.txt  |   10 +-
 .../mac/tables/mozilla/bugs/bug30692-expected.txt  |   20 +-
 67 files changed, 1886 insertions(+), 1663 deletions(-)

[Ojan Vafai]

Created attachment 28568 [details]
Put the padding inside scrollbars on textareas.

 WebCore/css/CSSStyleSelector.cpp                  |    6 ++
 WebCore/rendering/RenderTextControl.cpp           |   61 +--------------------
 WebCore/rendering/RenderTextControl.h             |   10 ----
 WebCore/rendering/RenderTextControlMultiLine.cpp  |   35 ++-----------
 WebCore/rendering/RenderTextControlMultiLine.h    |    1 -
 WebCore/rendering/RenderTextControlSingleLine.cpp |   57 +++++++++++++++++++
 WebCore/rendering/RenderTextControlSingleLine.h   |   11 ++++
 WebCore/rendering/TextControlInnerElements.cpp    |   30 ++++++++++-
 8 files changed, 109 insertions(+), 102 deletions(-)

[Ojan Vafai]

Comment on attachment 28378 [details]
LayoutTest rebaselines after moving padding inside scrollbars on textareas.

New patch that syncs to trunk obsoletes this one.

[Ojan Vafai]

Comment on attachment 28447 [details]
Put the padding inside scrollbars on textareas.

New patch that syncs to trunk obsoletes this one.

[Ojan Vafai]

At Eric's suggestion, I'm rewriting the textarea tests that I'm adding to be JS tests. The rest is still ready for review though.

[Ojan Vafai]

Created attachment 28599 [details]
Add new textarea tests.

 LayoutTests/ChangeLog                              |   13 +
 LayoutTests/fast/forms/basic-textareas.html        |   97 ++
 .../fast/forms/basic-textareas-expected.checksum   |    1 +
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 0 -> 114444 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    | 1162 ++++++++++++++++++++
 5 files changed, 1273 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 28599 [details]
Add new textarea tests.

Pretty fancy.

[Ojan Vafai]

Created attachment 28604 [details]
Add new textarea tests.

 LayoutTests/ChangeLog                              |   13 +
 LayoutTests/fast/forms/basic-textareas.html        |   97 ++
 .../linebox-overflow-in-textarea-padding.html      |   22 +
 .../fast/forms/basic-textareas-expected.checksum   |    1 +
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 0 -> 114444 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    | 1162 ++++++++++++++++++++
 ...-overflow-in-textarea-padding-expected.checksum |    1 +
 ...nebox-overflow-in-textarea-padding-expected.png |  Bin 0 -> 20697 bytes
 ...nebox-overflow-in-textarea-padding-expected.txt |   26 +
 9 files changed, 1322 insertions(+), 0 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 28604 [details]
Add new textarea tests.

Still seems fine.

[Eric Seidel (no email)]

Comment on attachment 28604 [details]
Add new textarea tests.

Sigh.  Of course git-send-bugzilla patch files don't include the actual data, so I can't really land this.

[Ojan Vafai]

Created attachment 28607 [details]
new textarea tests made with git format-patch so eseidel can land them.

[Eric Seidel (no email)]

Comment on attachment 28607 [details]
new textarea tests made with git format-patch so eseidel can land them.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/forms/basic-textareas.html
	A	LayoutTests/fast/forms/linebox-overflow-in-textarea-padding.html
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.checksum
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
	A	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum
	A	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png
	A	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt
Committed r41690

[Ojan Vafai]

Created attachment 28610 [details]
LayoutTest rebaselines after moving padding inside scrollbars on textareas.

 .../mac/editing/inserting/4960120-1-expected.txt   |   14 +-
 .../nested-blocks-with-text-area-expected.txt      |   10 +-
 .../editing/pasteboard/pasting-tabs-expected.txt   |   10 +-
 .../fast/block/margin-collapse/103-expected.txt    |   30 +-
 .../fast/css/resize-corner-tracking-expected.txt   |   12 +-
 .../reset-textarea-expected.txt                    |   16 +-
 .../platform/mac/fast/dynamic/008-expected.txt     |   10 +-
 .../fast/forms/basic-textareas-expected.checksum   |    2 +-
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 114444 -> 116809 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    | 1620 ++++++++++----------
 .../forms/basic-textareas-quirks-expected.checksum |    1 +
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 0 -> 115468 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt |  822 ++++++++++
 .../fast/forms/form-element-geometry-expected.txt  |   20 +-
 ...-overflow-in-textarea-padding-expected.checksum |    2 +-
 ...nebox-overflow-in-textarea-padding-expected.png |  Bin 20697 -> 20849 bytes
 ...nebox-overflow-in-textarea-padding-expected.txt |   14 +-
 .../mac/fast/forms/negativeLineHeight-expected.txt |   14 +-
 .../mac/fast/forms/textAreaLineHeight-expected.txt |   48 +-
 .../mac/fast/forms/textarea-align-expected.txt     |   50 +-
 .../mac/fast/forms/textarea-rows-cols-expected.txt |  204 ++--
 .../fast/forms/textarea-scroll-height-expected.txt |   88 +-
 .../mac/fast/forms/textarea-scrollbar-expected.txt |   60 +-
 .../fast/forms/textarea-scrolled-type-expected.txt |   90 +-
 .../fast/forms/textarea-setinnerhtml-expected.txt  |   10 +-
 .../mac/fast/forms/textarea-width-expected.txt     |   16 +-
 .../mac/fast/overflow/overflow-x-y-expected.txt    |   18 +-
 .../fast/parser/comment-in-textarea-expected.txt   |   22 +-
 .../parser/entity-comment-in-textarea-expected.txt |   12 +-
 .../parser/open-comment-in-textarea-expected.txt   |   22 +-
 .../replaced/width100percent-textarea-expected.txt |   84 +-
 .../platform/mac/fast/table/003-expected.txt       |    6 +-
 .../rtl-white-space-pre-wrap-expected.txt          |   14 +-
 .../tests/navigation/anchor-basic-expected.txt     |   14 +-
 .../tests/navigation/anchor-frames-expected.txt    |   14 +-
 .../tests/navigation/anchor-goback-expected.txt    |   18 +-
 .../navigation/anchor-subframeload-expected.txt    |   14 +-
 .../navigation/javascriptlink-basic-expected.txt   |   14 +-
 .../navigation/javascriptlink-frames-expected.txt  |   14 +-
 .../navigation/javascriptlink-goback-expected.txt  |   18 +-
 .../javascriptlink-subframeload-expected.txt       |   14 +-
 .../navigation/metaredirect-basic-expected.txt     |   14 +-
 .../navigation/metaredirect-frames-expected.txt    |   14 +-
 .../navigation/metaredirect-goback-expected.txt    |   18 +-
 .../metaredirect-subframeload-expected.txt         |   14 +-
 .../tests/navigation/post-goback2-expected.txt     |   18 +-
 .../navigation/postredirect-goback2-expected.txt   |   18 +-
 .../navigation/redirect302-basic-expected.txt      |   14 +-
 .../navigation/redirect302-frames-expected.txt     |   14 +-
 .../navigation/redirect302-goback-expected.txt     |   18 +-
 .../redirect302-subframeload-expected.txt          |   14 +-
 .../navigation/relativeanchor-basic-expected.txt   |   14 +-
 .../navigation/relativeanchor-frames-expected.txt  |   14 +-
 .../navigation/relativeanchor-goback-expected.txt  |   14 +-
 .../navigation/slowmetaredirect-basic-expected.txt |   14 +-
 .../slowtimerredirect-basic-expected.txt           |   14 +-
 .../tests/navigation/success200-basic-expected.txt |   14 +-
 .../navigation/success200-frames-expected.txt      |   14 +-
 .../success200-frames-loadsame-expected.txt        |   14 +-
 .../navigation/success200-goback-expected.txt      |   18 +-
 .../navigation/success200-loadsame-expected.txt    |   14 +-
 .../navigation/success200-reload-expected.txt      |   14 +-
 .../success200-subframeload-expected.txt           |   14 +-
 .../navigation/timerredirect-basic-expected.txt    |   14 +-
 .../navigation/timerredirect-frames-expected.txt   |   14 +-
 .../navigation/timerredirect-goback-expected.txt   |   18 +-
 .../timerredirect-subframeload-expected.txt        |   14 +-
 .../mac/tables/mozilla/bugs/bug194024-expected.txt |   90 +-
 .../mac/tables/mozilla/bugs/bug30559-expected.txt  |   10 +-
 .../mac/tables/mozilla/bugs/bug30692-expected.txt  |   20 +-
 70 files changed, 2391 insertions(+), 1578 deletions(-)

[Ojan Vafai]

Created attachment 28611 [details]
Layout test rebaselines patch made with git format-patch so binary files will work.

[Ojan Vafai]

Created attachment 28668 [details]
LayoutTest rebaselines after moving padding inside scrollbars on textareas.

 .../mac/editing/inserting/4960120-1-expected.txt   |   14 +-
 .../nested-blocks-with-text-area-expected.txt      |   10 +-
 .../editing/pasteboard/pasting-tabs-expected.txt   |   10 +-
 .../fast/block/margin-collapse/103-expected.txt    |   30 +-
 .../fast/css/resize-corner-tracking-expected.txt   |   12 +-
 .../reset-textarea-expected.txt                    |   16 +-
 .../platform/mac/fast/dynamic/008-expected.txt     |   10 +-
 .../fast/forms/basic-textareas-expected.checksum   |    2 +-
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 114444 -> 116809 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    | 1620 ++++++++++----------
 .../forms/basic-textareas-quirks-expected.checksum |    1 +
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 0 -> 115468 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt |  822 ++++++++++
 .../fast/forms/form-element-geometry-expected.txt  |   20 +-
 ...-overflow-in-textarea-padding-expected.checksum |    2 +-
 ...nebox-overflow-in-textarea-padding-expected.png |  Bin 20977 -> 20931 bytes
 ...nebox-overflow-in-textarea-padding-expected.txt |   14 +-
 .../mac/fast/forms/negativeLineHeight-expected.txt |   14 +-
 .../mac/fast/forms/textAreaLineHeight-expected.txt |   48 +-
 .../mac/fast/forms/textarea-align-expected.txt     |   50 +-
 .../mac/fast/forms/textarea-rows-cols-expected.txt |  204 ++--
 .../fast/forms/textarea-scroll-height-expected.txt |   88 +-
 .../mac/fast/forms/textarea-scrollbar-expected.txt |   60 +-
 .../fast/forms/textarea-scrolled-type-expected.txt |   90 +-
 .../fast/forms/textarea-setinnerhtml-expected.txt  |   10 +-
 .../mac/fast/forms/textarea-width-expected.txt     |   16 +-
 .../mac/fast/overflow/overflow-x-y-expected.txt    |   18 +-
 .../fast/parser/comment-in-textarea-expected.txt   |   22 +-
 .../parser/entity-comment-in-textarea-expected.txt |   12 +-
 .../parser/open-comment-in-textarea-expected.txt   |   22 +-
 .../replaced/width100percent-textarea-expected.txt |   84 +-
 .../platform/mac/fast/table/003-expected.txt       |    6 +-
 .../rtl-white-space-pre-wrap-expected.txt          |   14 +-
 .../tests/navigation/anchor-basic-expected.txt     |   14 +-
 .../tests/navigation/anchor-frames-expected.txt    |   14 +-
 .../tests/navigation/anchor-goback-expected.txt    |   18 +-
 .../navigation/anchor-subframeload-expected.txt    |   14 +-
 .../navigation/javascriptlink-basic-expected.txt   |   14 +-
 .../navigation/javascriptlink-frames-expected.txt  |   14 +-
 .../navigation/javascriptlink-goback-expected.txt  |   18 +-
 .../javascriptlink-subframeload-expected.txt       |   14 +-
 .../navigation/metaredirect-basic-expected.txt     |   14 +-
 .../navigation/metaredirect-frames-expected.txt    |   14 +-
 .../navigation/metaredirect-goback-expected.txt    |   18 +-
 .../metaredirect-subframeload-expected.txt         |   14 +-
 .../tests/navigation/post-goback2-expected.txt     |   18 +-
 .../navigation/postredirect-goback2-expected.txt   |   18 +-
 .../navigation/redirect302-basic-expected.txt      |   14 +-
 .../navigation/redirect302-frames-expected.txt     |   14 +-
 .../navigation/redirect302-goback-expected.txt     |   18 +-
 .../redirect302-subframeload-expected.txt          |   14 +-
 .../navigation/relativeanchor-basic-expected.txt   |   14 +-
 .../navigation/relativeanchor-frames-expected.txt  |   14 +-
 .../navigation/relativeanchor-goback-expected.txt  |   14 +-
 .../navigation/slowmetaredirect-basic-expected.txt |   14 +-
 .../slowtimerredirect-basic-expected.txt           |   14 +-
 .../tests/navigation/success200-basic-expected.txt |   14 +-
 .../navigation/success200-frames-expected.txt      |   14 +-
 .../success200-frames-loadsame-expected.txt        |   14 +-
 .../navigation/success200-goback-expected.txt      |   18 +-
 .../navigation/success200-loadsame-expected.txt    |   14 +-
 .../navigation/success200-reload-expected.txt      |   14 +-
 .../success200-subframeload-expected.txt           |   14 +-
 .../navigation/timerredirect-basic-expected.txt    |   14 +-
 .../navigation/timerredirect-frames-expected.txt   |   14 +-
 .../navigation/timerredirect-goback-expected.txt   |   18 +-
 .../timerredirect-subframeload-expected.txt        |   14 +-
 .../mac/tables/mozilla/bugs/bug194024-expected.txt |   90 +-
 .../mac/tables/mozilla/bugs/bug30559-expected.txt  |   10 +-
 .../mac/tables/mozilla/bugs/bug30692-expected.txt  |   20 +-
 70 files changed, 2391 insertions(+), 1578 deletions(-)

[Ojan Vafai]

Created attachment 28671 [details]
git format-patch version of test rebaselines for easier patching/committing

[Ojan Vafai]

Created attachment 28702 [details]
Put the padding inside scrollbars on textareas.

 LayoutTests/ChangeLog                              |   77 +
 .../mac/editing/inserting/4960120-1-expected.txt   |   14 +-
 .../nested-blocks-with-text-area-expected.txt      |   10 +-
 .../editing/pasteboard/pasting-tabs-expected.txt   |   10 +-
 .../fast/block/margin-collapse/103-expected.txt    |   30 +-
 .../fast/css/resize-corner-tracking-expected.txt   |   12 +-
 .../reset-textarea-expected.txt                    |   16 +-
 .../platform/mac/fast/dynamic/008-expected.txt     |   10 +-
 .../fast/forms/basic-textareas-expected.checksum   |    2 +-
 .../mac/fast/forms/basic-textareas-expected.png    |  Bin 114444 -> 116809 bytes
 .../mac/fast/forms/basic-textareas-expected.txt    | 1620 ++++++++++----------
 .../forms/basic-textareas-quirks-expected.checksum |    1 +
 .../fast/forms/basic-textareas-quirks-expected.png |  Bin 0 -> 115468 bytes
 .../fast/forms/basic-textareas-quirks-expected.txt |  822 ++++++++++
 .../fast/forms/form-element-geometry-expected.txt  |   20 +-
 ...-overflow-in-textarea-padding-expected.checksum |    2 +-
 ...nebox-overflow-in-textarea-padding-expected.png |  Bin 20977 -> 20931 bytes
 ...nebox-overflow-in-textarea-padding-expected.txt |   14 +-
 .../mac/fast/forms/negativeLineHeight-expected.txt |   14 +-
 .../mac/fast/forms/textAreaLineHeight-expected.txt |   48 +-
 .../mac/fast/forms/textarea-align-expected.txt     |   50 +-
 .../mac/fast/forms/textarea-rows-cols-expected.txt |  204 ++--
 .../fast/forms/textarea-scroll-height-expected.txt |   88 +-
 .../mac/fast/forms/textarea-scrollbar-expected.txt |   60 +-
 .../fast/forms/textarea-scrolled-type-expected.txt |   90 +-
 .../fast/forms/textarea-setinnerhtml-expected.txt  |   10 +-
 .../mac/fast/forms/textarea-width-expected.txt     |   16 +-
 .../mac/fast/overflow/overflow-x-y-expected.txt    |   18 +-
 .../fast/parser/comment-in-textarea-expected.txt   |   22 +-
 .../parser/entity-comment-in-textarea-expected.txt |   12 +-
 .../parser/open-comment-in-textarea-expected.txt   |   22 +-
 .../replaced/width100percent-textarea-expected.txt |   84 +-
 .../platform/mac/fast/table/003-expected.txt       |    6 +-
 .../rtl-white-space-pre-wrap-expected.txt          |   14 +-
 .../tests/navigation/anchor-basic-expected.txt     |   14 +-
 .../tests/navigation/anchor-frames-expected.txt    |   14 +-
 .../tests/navigation/anchor-goback-expected.txt    |   18 +-
 .../navigation/anchor-subframeload-expected.txt    |   14 +-
 .../navigation/javascriptlink-basic-expected.txt   |   14 +-
 .../navigation/javascriptlink-frames-expected.txt  |   14 +-
 .../navigation/javascriptlink-goback-expected.txt  |   18 +-
 .../javascriptlink-subframeload-expected.txt       |   14 +-
 .../navigation/metaredirect-basic-expected.txt     |   14 +-
 .../navigation/metaredirect-frames-expected.txt    |   14 +-
 .../navigation/metaredirect-goback-expected.txt    |   18 +-
 .../metaredirect-subframeload-expected.txt         |   14 +-
 .../tests/navigation/post-goback2-expected.txt     |   18 +-
 .../navigation/postredirect-goback2-expected.txt   |   18 +-
 .../navigation/redirect302-basic-expected.txt      |   14 +-
 .../navigation/redirect302-frames-expected.txt     |   14 +-
 .../navigation/redirect302-goback-expected.txt     |   18 +-
 .../redirect302-subframeload-expected.txt          |   14 +-
 .../navigation/relativeanchor-basic-expected.txt   |   14 +-
 .../navigation/relativeanchor-frames-expected.txt  |   14 +-
 .../navigation/relativeanchor-goback-expected.txt  |   14 +-
 .../navigation/slowmetaredirect-basic-expected.txt |   14 +-
 .../slowtimerredirect-basic-expected.txt           |   14 +-
 .../tests/navigation/success200-basic-expected.txt |   14 +-
 .../navigation/success200-frames-expected.txt      |   14 +-
 .../success200-frames-loadsame-expected.txt        |   14 +-
 .../navigation/success200-goback-expected.txt      |   18 +-
 .../navigation/success200-loadsame-expected.txt    |   14 +-
 .../navigation/success200-reload-expected.txt      |   14 +-
 .../success200-subframeload-expected.txt           |   14 +-
 .../navigation/timerredirect-basic-expected.txt    |   14 +-
 .../navigation/timerredirect-frames-expected.txt   |   14 +-
 .../navigation/timerredirect-goback-expected.txt   |   18 +-
 .../timerredirect-subframeload-expected.txt        |   14 +-
 .../mac/tables/mozilla/bugs/bug194024-expected.txt |   90 +-
 .../mac/tables/mozilla/bugs/bug30559-expected.txt  |   10 +-
 .../mac/tables/mozilla/bugs/bug30692-expected.txt  |   20 +-
 WebCore/ChangeLog                                  |   34 +
 WebCore/css/CSSStyleSelector.cpp                   |    6 +
 WebCore/rendering/RenderTextControl.cpp            |   61 +-
 WebCore/rendering/RenderTextControl.h              |   10 -
 WebCore/rendering/RenderTextControlMultiLine.cpp   |   35 +-
 WebCore/rendering/RenderTextControlMultiLine.h     |    1 -
 WebCore/rendering/RenderTextControlSingleLine.cpp  |   57 +
 WebCore/rendering/RenderTextControlSingleLine.h    |   11 +
 WebCore/rendering/TextControlInnerElements.cpp     |   30 +-
 80 files changed, 2611 insertions(+), 1680 deletions(-)

[Ojan Vafai]

Created attachment 28703 [details]
git format-patch version for easier patching/committing

[Adele Peterson]

Comment on attachment 28702 [details]
Put the padding inside scrollbars on textareas.

Ojan clarified some of this over IRC.  r=me!

[Ojan Vafai]

Both adele and eric asked for a more descriptive changelog:

Put the padding inside the scrollbars on textareas. This is done by moving the overflow from the shadowNode to the RenderTextControlMultiline. As a result, all of the scroll handing methods that RenderTextControl overrides can be moved down into RenderTextControlSingleLine since RenderTextControlMultiline can now just use RenderBlock's versions. This also allows RenderTextControlMultiLine to no longer need a custom layout method since the shadowNode can now just size like a regular DIV.

Almost all of the test rebaselines are just the textarea moving into the layer now that the overflow is on the textarea instead of it's shadowNode. There area a couple pixel test rebaselines where the scrollbars move and text wraps differently now that the padding is inside the scrollbars.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/mac/editing/inserting/4960120-1-expected.txt
	M	LayoutTests/platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt
	M	LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.txt
	M	LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt
	M	LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt
	M	LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt
	M	LayoutTests/platform/mac/fast/dynamic/008-expected.txt
	M	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.checksum
	M	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png
	M	LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.checksum
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png
	A	LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt
	M	LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt
	M	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum
	M	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png
	M	LayoutTests/platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt
	M	LayoutTests/platform/mac/fast/forms/negativeLineHeight-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-rows-cols-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-scroll-height-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-scrollbar-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt
	M	LayoutTests/platform/mac/fast/forms/textarea-width-expected.txt
	M	LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt
	M	LayoutTests/platform/mac/fast/parser/comment-in-textarea-expected.txt
	M	LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt
	M	LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt
	M	LayoutTests/platform/mac/fast/replaced/width100percent-textarea-expected.txt
	M	LayoutTests/platform/mac/fast/table/003-expected.txt
	M	LayoutTests/platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/anchor-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/anchor-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/anchor-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/anchor-subframeload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/metaredirect-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/metaredirect-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/metaredirect-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/post-goback2-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/postredirect-goback2-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/redirect302-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/redirect302-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/redirect302-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-loadsame-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-reload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/success200-subframeload-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/timerredirect-basic-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/timerredirect-frames-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/timerredirect-goback-expected.txt
	M	LayoutTests/platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla/bugs/bug194024-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla/bugs/bug30559-expected.txt
	M	LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt
	M	WebCore/ChangeLog
	M	WebCore/css/CSSStyleSelector.cpp
	M	WebCore/rendering/RenderTextControl.cpp
	M	WebCore/rendering/RenderTextControl.h
	M	WebCore/rendering/RenderTextControlMultiLine.cpp
	M	WebCore/rendering/RenderTextControlMultiLine.h
	M	WebCore/rendering/RenderTextControlSingleLine.cpp
	M	WebCore/rendering/RenderTextControlSingleLine.h
	M	WebCore/rendering/TextControlInnerElements.cpp
Committed r41792

[Steven Lai]

There is a regression bug:
https://bugs.webkit.org/show_bug.cgi?id=38506