Bug 24356

Summary:

Rename AllowUniversalAccessFromFileUrls to AllowUniversalAccessFromFileURLs

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	ap: review+

Adam Barth

Reported 2009-03-04 09:31:32 PST

WebKit style fail.

Attachments
patch (17.23 KB, patch) 2009-03-04 10:00 PST, Adam Barth	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2009-03-04 10:00:05 PST

Per bug 24340 comment 4, Qt API should probably remain an exception.

Adam Barth

Comment 2 2009-03-04 10:00:21 PST

Created attachment 28267 [details] patch I left the Qt parts in Qt style (i.e., Url).

Alexey Proskuryakov

Comment 3 2009-03-04 11:24:06 PST

Comment on attachment 28267 [details] patch r=me. Thanks! - } else if(settings->allowUniversalAccessFromFileUrls() && securityOrigin()->isLocal()) { + } else if(settings->allowUniversalAccessFromFileURLs() && securityOrigin()->isLocal()) { Please add a space after if here.

Adam Barth

Comment 4 2009-03-04 11:59:00 PST

Sending WebCore/ChangeLog Sending WebCore/WebCore.base.exp Sending WebCore/dom/Document.cpp Sending WebCore/page/Settings.cpp Sending WebCore/page/Settings.h Sending WebKit/mac/ChangeLog Sending WebKit/mac/WebView/WebPreferenceKeysPrivate.h Sending WebKit/mac/WebView/WebPreferences.mm Sending WebKit/mac/WebView/WebPreferencesPrivate.h Sending WebKit/mac/WebView/WebView.mm Sending WebKit/qt/Api/qwebsettings.cpp Sending WebKit/qt/ChangeLog Sending WebKit/win/ChangeLog Sending WebKit/win/Interfaces/IWebPreferencesPrivate.idl Sending WebKit/win/WebPreferenceKeysPrivate.h Sending WebKit/win/WebPreferences.cpp Sending WebKit/win/WebPreferences.h Sending WebKit/win/WebView.cpp Transmitting file data .................. Committed revision 41426. I'll mark this bug as fixed once the buildbots give us the green light.

Note You need to log in before you can comment on or make changes to this bug.