Summary: | [CSS Container Queries] Update query grammar to the spec | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, joepeck, macpherson, menard, ntim, pangle, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 229659 | ||||||||||||
Attachments: |
|
Description
Antti Koivisto
2022-08-02 02:39:31 PDT
Created attachment 461354 [details]
Patch
Created attachment 461355 [details]
Patch
Comment on attachment 461355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461355&action=review > Source/WebCore/css/ContainerQueryParser.cpp:98 > For posterity (and anyone else looking at this patch), the `not` part is handled just below (click expand to make it appear in the diff view). > Source/WebCore/css/StyleRule.cpp:466 > + , m_containerdQuery(WTFMove(query)) > { > } > > StyleRuleContainer::StyleRuleContainer(const StyleRuleContainer& other) > : StyleRuleGroup(other) > - , m_filteredQuery(other.m_filteredQuery) > + , m_containerdQuery(other.m_containerdQuery) typo: m_containerdQuery (extra d) > Source/WebCore/css/StyleRule.h:303 > + CQ::ContainerQuery m_containerdQuery; ditto in this file Created attachment 461357 [details]
Patch for landing
Commit message contains (OOPS!), blocking PR #None Created attachment 461358 [details]
Patch for landing
Committed 253035@main (2956c932c8f4): <https://commits.webkit.org/253035@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461358 [details]. |