Bug 24340 – Expose allowUniversalAccessFromFileUrls to Qt

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Adam Barth]

Clients of the QT port might want to set allowUniversalAccessFromFileUrls.  We should expose it in http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebsettings.h

[Adam Barth]

Created attachment 28252 [details]
patch

I can't build QT, but this patch is trivially simple (meaning it will probably only break the build in two ways).

[Alexey Proskuryakov]

QT is QuickTime, re-titling.

[Alexey Proskuryakov]

Comment on attachment 28252 [details]
patch

+        Reviewed by NOBODY (OOPS!).
+
+        Expose AllowUniversalAccessFromFileUrls to QT clients.

Please add a bug URL.

r=me, but AllowUniversalAccessFromFileUrls should really be AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's particularly unfortunate to have this exposed as a (private) preference, could you please rename all instances? A separate patch would probably be more appropriate.

[Brian Ellis]

(In reply to comment #3)

> r=me, but AllowUniversalAccessFromFileUrls should really be
> AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's
> particularly unfortunate to have this exposed as a (private) preference, could
> you please rename all instances? A separate patch would probably be more
> appropriate.

"URL" is consistent with the naming of preferences in WebCore, but Qt uses "Url" instead of "URL" pretty universally -- see e.g. the QUrl class and the QWebPage method "userAgentForUrl".  Perhaps it should be left alone in QtWebKit and changed elsewhere?

[Adam Barth]

> could you please rename all instances? A separate patch would probably be more
> appropriate.

Filed as: https://bugs.webkit.org/show_bug.cgi?id=24356

[Adam Barth]

Sending        WebKit/qt/Api/qwebsettings.cpp
Sending        WebKit/qt/Api/qwebsettings.h
Sending        WebKit/qt/ChangeLog
Transmitting file data ...
Committed revision 41421.