Bug 243138

Summary: [LFC][IFC] Add support for text-emphasis
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 243137, 243139, 243140, 243141, 243142, 243143, 243144    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2022-07-23 14:13:15 PDT
ssia
Attachments
Patch (3.03 KB, patch)
2022-07-23 16:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.01 KB, patch)
2022-07-23 16:28 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (16.44 KB, patch)
2022-07-27 13:46 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-07-23 16:19:23 PDT
Created attachment 461167 [details] Patch
alan
Comment 2 2022-07-23 16:22:57 PDT
1. Enable text-emphasis painting for modern line layout codepath 2. Add support for float based emphasis content height 3. InlineLevelBox caches annotation content height 4. Bail out of simplified vertical alignment when annotation is present 5. Prepare LineBoxVerticalAligner for dealing with annotation adjustment 6. Implement vertical alignment with annotation 7. Adjust enclosing content geometry/ink overflow with annotation content size
alan
Comment 3 2022-07-23 16:28:45 PDT
Created attachment 461168 [details] Patch
alan
Comment 4 2022-07-27 13:46:41 PDT
Created attachment 461261 [details] [fast-cq]Patch
EWS
Comment 5 2022-07-27 19:05:25 PDT
Committed 252889@main (574ed4eaf203): <https://commits.webkit.org/252889@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461261 [details].
Radar WebKit Bug Importer
Comment 6 2022-07-27 19:06:17 PDT
<rdar://problem/97697028>
Note You need to log in before you can comment on or make changes to this bug.