Bug 24312

Summary: Hit test through 3d transforms
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dino, hausmann, hyatt, kari.hiitola, kim.1.gronholm
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 24313, 24317    
Bug Blocks: 23359    
Attachments:
Description Flags
Patch, changelog.
hyatt: review+
Prequel patch: refactor code into transformFromContainer() hyatt: review+

Simon Fraser (smfr)
Reported 2009-03-02 20:08:56 PST
We need to have hit testing be aware of 3d transforms, and preserve-3d style.
Attachments
Patch, changelog. (33.79 KB, patch)
2009-03-02 23:39 PST, Simon Fraser (smfr)
hyatt: review+
Prequel patch: refactor code into transformFromContainer() (7.14 KB, patch)
2009-03-03 09:10 PST, Simon Fraser (smfr)
hyatt: review+
Simon Fraser (smfr)
Comment 1 2009-03-02 23:39:57 PST
Created attachment 28214 [details] Patch, changelog. Testcases will be added once we turn on support for 3d rendering.
Simon Fraser (smfr)
Comment 2 2009-03-03 09:10:35 PST
Created attachment 28224 [details] Prequel patch: refactor code into transformFromContainer()
Dave Hyatt
Comment 3 2009-03-03 09:13:25 PST
Comment on attachment 28224 [details] Prequel patch: refactor code into transformFromContainer() > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index e7b3153..0256ec1 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -2,6 +2,22 @@ > > Reviewed by NOBODY (OOPS!). > > + https://bugs.webkit.org/show_bug.cgi?id=24312 > + > + Factor the code that compute a transform relative to the container > + into RenderObject::transformFromContainer(). > + "that computes a transform" r=me
Dave Hyatt
Comment 4 2009-03-03 09:19:09 PST
Comment on attachment 28214 [details] Patch, changelog. "Recurses through the layer hieraarchy" Actually just remove this comment. I think it's just confusing. hit testing doesn't go through the parent/child hierarchy, which is what the comment implies.
Simon Fraser (smfr)
Comment 5 2009-03-03 09:53:34 PST
Simon Fraser (smfr)
Comment 6 2009-03-03 10:11:05 PST
Simon Fraser (smfr)
Comment 7 2009-03-13 08:28:47 PDT
*** Bug 24573 has been marked as a duplicate of this bug. ***
Kari Hiitola
Comment 8 2009-03-19 06:21:15 PDT
I tested with the latest nightly on a Mac, and the hit testing really doesn't seem to work as it should. If you try the test page of the duplicate bug: https://bugs.webkit.org/attachment.cgi?id=28576 the child div can not be clicked. I would suggest reopening this bug.
Simon Fraser (smfr)
Comment 9 2009-03-19 09:22:54 PDT
Kari: I believe the issue that breaks your is covered by bug 24659.
Note You need to log in before you can comment on or make changes to this bug.