Bug 242242
| Summary: | [browserperfdash-benchmark] Fix error logging from server after 251530@main (port to python3) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, aperez, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=230098 | ||
Carlos Alberto Lopez Perez
On 251530@main (r295525) the script browserperfdash-runner was ported to python3 and it is working fine.
However, when the browserperfdash server replies with an error (http error code: 400) the script is not longer logging what caused the error (the body of the http reply) on stderr.
Instead it is causing a generic exception that doesn't give any helpful info for debugging the problem.
Previously (with python2) the script was giving useful info. This seems to be caused because on python3 urllib.request.urlopen always rises when the http error code is not 200.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/1989
EWS
Committed 252040@main (c0299cc3d772): <https://commits.webkit.org/252040@main>
Reviewed commits have been landed. Closing PR #1989 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/96290581>