Summary: | ScriptInstance.h missing an #include | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Mentovai <mark> | ||||
Component: | WebCore Misc. | Assignee: | Mark Mentovai <mark> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 24109 | ||||||
Attachments: |
|
Description
Mark Mentovai
2009-02-24 14:39:55 PST
Created attachment 27937 [details]
fix
Comment on attachment 27937 [details]
fix
Looks OK.
I break builds because it gives me false sense of power which offers momentary relief of the overwhelming feeling of insecurity. BTW, why are you using these? I haven't updated the projects to use them yet :) The gyp-based build is not bound by your puny project files. I look for added files after WebKit merges and add them. It's the only way to keep myself green. Well, be careful young Jedi. The files in bindings/v8/custom lack corresponding inliners in V8Proxy, which I haven't yet landed. Thanks, I'll pull them back out if I have to. I was wondering how the missing #include didn't break any of the "proper" builds. This change should still be checked in. Landed as http://trac.webkit.org/changeset/41194. |