Bug 241225

Summary:

[CSS Container Queries] Re-evaluate queries after subframe size changes

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

229659

Attachments:

Description	Flags
Patch	koivisto: commit-queue+
Patch	none
Patch for landing	none
Patch	none
Patch	none
Patch for landing	none

Antti Koivisto

Reported 2022-06-02 06:16:13 PDT

We fail to update on frame size change.

Attachments
Patch (12.12 KB, patch) 2022-06-02 06:24 PDT, Antti Koivisto	koivisto: commit-queue+	Details Formatted Diff Diff
Patch (12.39 KB, patch) 2022-06-02 09:08 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch for landing (12.40 KB, patch) 2022-06-02 09:12 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (12.33 KB, patch) 2022-06-02 09:36 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch (11.47 KB, patch) 2022-06-02 09:50 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Patch for landing (11.47 KB, patch) 2022-06-03 01:45 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2022-06-02 06:24:13 PDT

Created attachment 459959 [details] Patch

zalan

Comment 2 2022-06-02 09:01:23 PDT

Comment on attachment 459959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459959&action=review > Source/WebCore/page/FrameViewLayoutContext.h:58 > + void layoutWithoutUpdatingQueryContainers(); I assume we are not planning on introducing too many new layout() callsites, so in practice having these 2 functions and deciding "which one to call when" won't cause any issues -but in theory it may be a bit puzzling which one to actually use. I guess if you don't know whether you need query containers, it's better to just use layout().

Antti Koivisto

Comment 3 2022-06-02 09:03:40 PDT

> I assume we are not planning on introducing too many new layout() callsites, > so in practice having these 2 functions and deciding "which one to call > when" won't cause any issues -but in theory it may be a bit puzzling which > one to actually use. I guess if you don't know whether you need query > containers, it's better to just use layout(). The idea is to just use layout() except in container query related code (there is one other call site for some stupid reasons).

Antti Koivisto

Comment 4 2022-06-02 09:08:04 PDT

Created attachment 459962 [details] Patch

Antti Koivisto

Comment 5 2022-06-02 09:12:38 PDT

Created attachment 459963 [details] Patch for landing

Antti Koivisto

Comment 6 2022-06-02 09:36:14 PDT

Created attachment 459964 [details] Patch

Antti Koivisto

Comment 7 2022-06-02 09:50:43 PDT

Created attachment 459965 [details] Patch