Bug 24109

Summary:

Upstream V8 Script Abstraction

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

24139

Bug Blocks:

Attachments:

Description	Flags
Add V8 Script abstractions, v1	eric: review+

Dimitri Glazkov (Google)

Reported 2009-02-23 15:52:22 PST

.. with the exception of ScriptController, which needs to have its own, highly personalized bathing.

Attachments
Add V8 Script abstractions, v1 (34.52 KB, patch) 2009-02-23 15:54 PST, Dimitri Glazkov (Google)	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-02-23 15:54:24 PST

Created attachment 27897 [details] Add V8 Script abstractions, v1 WebCore/ChangeLog | 66 +++++++++++++ WebCore/bindings/v8/ScriptCachedFrameData.h | 52 ++++++++++ WebCore/bindings/v8/ScriptCallFrame.cpp | 62 ++++++++++++ WebCore/bindings/v8/ScriptCallFrame.h | 73 +++++++++++++++ WebCore/bindings/v8/ScriptCallStack.cpp | 58 ++++++++++++ WebCore/bindings/v8/ScriptCallStack.h | 59 ++++++++++++ WebCore/bindings/v8/ScriptInstance.cpp | 83 +++++++++++++++++ WebCore/bindings/v8/ScriptInstance.h | 63 +++++++++++++ WebCore/bindings/v8/ScriptSourceCode.h | 72 ++++++++++++++ WebCore/bindings/v8/ScriptState.h | 51 ++++++++++ WebCore/bindings/v8/ScriptString.h | 66 +++++++++++++ WebCore/bindings/v8/ScriptValue.cpp | 50 ++++++++++ WebCore/bindings/v8/ScriptValue.h | 134 +++++++++++++++++++++++++++ 13 files changed, 889 insertions(+), 0 deletions(-)

Eric Seidel (no email)

Comment 2 2009-02-23 15:58:11 PST

Comment on attachment 27897 [details] Add V8 Script abstractions, v1 Looks fine. Only touches V8 code.

Mark Rowe (bdash)

Comment 3 2009-02-23 17:00:46 PST

Did this get landed?

Dimitri Glazkov (Google)

Comment 4 2009-02-23 20:05:27 PST

Landed as http://trac.webkit.org/changeset/41159.

Note You need to log in before you can comment on or make changes to this bug.