Bug 240754
| Summary: | Make the StringView(const char*) constructor explicit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=241207 https://bugs.webkit.org/show_bug.cgi?id=241380 |
||
| Bug Depends on: | 240687 | ||
| Bug Blocks: | |||
Chris Dumez
Make the StringView(const char*) constructor private, to encourage people to use ASCIILiteral / ""_s. StringView::fromLatin1() is still available when the caller really has a non-string literal.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/879
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/930
EWS
Committed r294852 (250986@main): <https://commits.webkit.org/250986@main>
Reviewed commits have been landed. Closing PR #930 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/93937438>