Bug 240732
Summary: | [git-webkit] Use --git-common-dir over hard-coded .git | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | gsnedders, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 239082 |
Jonathan Bedard
As Sam Sneddon pointed out, using a hard coded .git to find our config location will break if folks are using git work trees. We should use `git rev-parse --git-common-dir` instead.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/93676555>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/851
Alexey Proskuryakov
*** Bug 240682 has been marked as a duplicate of this bug. ***
EWS
Committed r294900 (251023@main): <https://commits.webkit.org/251023@main>
Reviewed commits have been landed. Closing PR #851 and removing active labels.