Bug 239924
| Summary: | Web Inspector: Update jsmin to 3.0.1 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
| Component: | Web Inspector | Assignee: | Philippe Normand <pnormand> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, pangle, tsavell, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 242086 | ||
Philippe Normand
Current version (2.0.9) is very slow:
time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js
real 1m21.234s
user 0m59.580s
sys 0m21.253s
Version 3.0.1 is much faster:
time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js
real 0m3.933s
user 0m3.899s
sys 0m0.018s
So I'll try an update.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/444
EWS
Committed r293767 (250246@main): <https://commits.webkit.org/250246@main>
Reviewed commits have been landed. Closing PR #444 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/92720918>
Truitt Savell
It looks like the changes in https://github.com/WebKit/WebKit/commit/057f942c764e9f79d38e88bca94b7e35549883b4
broke inspector/timeline/line-column.html
tracking in:
https://bugs.webkit.org/show_bug.cgi?id=240291
Patrick Angle
This broke minifying WebInspectorUI. Specifically, the comment in CodeMirrorCompletionController.js `// FIXME: Include module keywords if we know this is a module environment.` is being kept in the minified output, most likely due to the regex above in the file. It appears to be this issue in the upstream project: https://github.com/tikitu/jsmin/issues/23