Bug 239734

Summary:

[css-logical] Border side shorthands should not be logical/physical

Product:

WebKit

Reporter:

Oriol Brufau <obrufau>

Component:

CSS

Assignee:

Oriol Brufau <obrufau>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, macpherson, menard, ntim, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

236199, 238888

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Oriol Brufau

Reported 2022-04-25 11:23:18 PDT

Currently, these shorthands belong to a logical property group: - border-top - border-right - border-bottom - border-left - border-block-start - border-block-end - border-inline-start - border-inline-end This doesn't make much sense, no need to e.g. map border-block-start to border-top, it should just expand to border-block-start-{width,style,color}. Then we can keep the special behavior confined to the longhands. Right now I don't think this is observable, but this refactoring is needed for bug 236199. My patch there (including this change) was previously reverted, so I guess it's safer to do the refactoring here.

Attachments
Patch (8.61 KB, patch) 2022-04-25 11:49 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Patch (9.56 KB, patch) 2022-04-25 12:00 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Patch (10.53 KB, patch) 2022-04-26 08:54 PDT, Oriol Brufau	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Oriol Brufau

Comment 1 2022-04-25 11:43:07 PDT

This change will also align the implementation with the spec: https://drafts.csswg.org/css-logical/#box > Each set of parallel flow-relative properties and physical properties (IGNORING SHORTHAND PROPERTIES) related by setting equivalent styles on the various sides or dimensions of a box, forms a logical property group.

Oriol Brufau

Comment 2 2022-04-25 11:49:07 PDT

Created attachment 458288 [details] Patch

Oriol Brufau

Comment 3 2022-04-25 12:00:02 PDT

Created attachment 458290 [details] Patch

Tim Nguyen (:ntim)

Comment 4 2022-04-25 17:27:24 PDT

Comment on attachment 458290 [details] Patch Thanks for fixing this!

Oriol Brufau

Comment 5 2022-04-26 08:54:16 PDT

Created attachment 458372 [details] Patch