Bug 238542

Summary: [CSS Container Queries] Keep colon syntax when serializing container condition
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, pangle, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/33423
Bug Depends on:    
Bug Blocks: 229659, 238346    
Attachments:
Description Flags
Patch
none
Patch none

Antti Koivisto
Reported 2022-03-30 02:31:12 PDT
Instead of always serializing using the range syntax.
Attachments
Patch (12.47 KB, patch)
2022-03-30 02:37 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (12.47 KB, patch)
2022-03-30 06:57 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-03-30 02:37:14 PDT
Created attachment 456105 [details] Patch
EWS Watchlist
Comment 2 2022-03-30 02:38:51 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Antti Koivisto
Comment 3 2022-03-30 06:57:59 PDT
Created attachment 456116 [details] Patch
Antti Koivisto
Comment 4 2022-03-30 06:58:24 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/33423
Tim Nguyen (:ntim)
Comment 5 2022-03-30 10:10:40 PDT
Comment on attachment 456116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456116&action=review > Source/WebCore/css/ContainerQuery.cpp:164 > + case Syntax::Range: Maybe assert that at least one of leftComparison or rightComparison is present.
Antti Koivisto
Comment 6 2022-03-30 10:52:42 PDT
> Maybe assert that at least one of leftComparison or rightComparison is > present. That's really just the boolean syntax case though I separated it for clarity.
EWS
Comment 7 2022-03-30 13:21:34 PDT
Committed r292117 (249030@main): <https://commits.webkit.org/249030@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456116 [details].
Radar WebKit Bug Importer
Comment 8 2022-03-30 13:22:27 PDT
<rdar://problem/91063095>
Note You need to log in before you can comment on or make changes to this bug.