| Summary: | [CSS Container Queries] Keep colon syntax when serializing container condition | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, pangle, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://github.com/web-platform-tests/wpt/pull/33423 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 229659, 238346 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2022-03-30 02:31:12 PDT
Created attachment 456105 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 456116 [details]
Patch
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/33423 Comment on attachment 456116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456116&action=review > Source/WebCore/css/ContainerQuery.cpp:164 > + case Syntax::Range: Maybe assert that at least one of leftComparison or rightComparison is present. > Maybe assert that at least one of leftComparison or rightComparison is
> present.
That's really just the boolean syntax case though I separated it for clarity.
Committed r292117 (249030@main): <https://commits.webkit.org/249030@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456116 [details]. |