Bug 237879

Summary: [WebGPU] Implement first draft of debug commands according to the spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237877    
Bug Blocks: 237882    
Attachments:
Description Flags
Patch
none
Patch
kkinnunen: review+
Patch for committing none

Myles C. Maxfield
Reported 2022-03-15 00:21:15 PDT
.
Attachments
Patch (4.43 KB, patch)
2022-03-15 00:22 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (15.25 KB, patch)
2022-03-15 00:48 PDT, Myles C. Maxfield 		kkinnunen: review+
DetailsFormatted DiffDiff
Patch for committing (15.08 KB, patch)
2022-03-16 20:30 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-15 00:22:51 PDT
Created attachment 454673 [details] Patch
Myles C. Maxfield
Comment 2 2022-03-15 00:48:13 PDT
Created attachment 454675 [details] Patch
Kimmo Kinnunen
Comment 3 2022-03-16 07:58:58 PDT
Comment on attachment 454675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review > Source/WebGPU/WebGPU/RenderPassEncoder.mm:112 > + // There's no direct way of doing this, so we just push/pop an empty debug group. is this comment still valid? below we seem to insert a signpost instead of an empty debug group
Myles C. Maxfield
Comment 4 2022-03-16 20:06:36 PDT
Comment on attachment 454675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review >> Source/WebGPU/WebGPU/RenderPassEncoder.mm:112 >> + // There's no direct way of doing this, so we just push/pop an empty debug group. > > is this comment still valid? below we seem to insert a signpost instead of an empty debug group Nope! Good catch.
Myles C. Maxfield
Comment 5 2022-03-16 20:30:47 PDT
Created attachment 454929 [details] Patch for committing
Myles C. Maxfield
Comment 6 2022-03-16 20:37:24 PDT
Committed r291386 (?): <https://commits.webkit.org/r291386>
Radar WebKit Bug Importer
Comment 7 2022-03-16 20:38:19 PDT
<rdar://problem/90407762>
Note You need to log in before you can comment on or make changes to this bug.