Bug 237677

Summary: MediaSampleCursor should iterate over the samples contained in the MediaSamplesBlock
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237594    
Bug Blocks: 236754    
Attachments:
Description Flags
Patch none

Jean-Yves Avenard [:jya]
Reported 2022-03-09 14:36:12 PST
Sub-task of bug 236754. In bug 237594; the MediaFormatReader was made to use MediaSamplesBlock as backend via MediaSampleRangeRequest's refactor. However, it only ever uses the last sample of the block, which is okay for now as there's no producer that create MediaSamplesBlock with more than one sample in it. However, the resolution for bug 236754 will change that pre-requisite. So we need the MediaSampleCursor to properly iterate over all the samples contained in the block.
Attachments
Patch (14.94 KB, patch)
2022-03-09 22:37 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-09 14:36:50 PST
<rdar://problem/90058029>
Jean-Yves Avenard [:jya]
Comment 2 2022-03-09 22:37:19 PST
Created attachment 454317 [details] Patch
EWS
Comment 3 2022-03-10 14:01:26 PST
Committed r291132 (248292@main): <https://commits.webkit.org/248292@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454317 [details].
Note You need to log in before you can comment on or make changes to this bug.