Bug 237527 – [GTK][WPE] Add initial adwaita style for PDF.js

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Initial adwaita style.

[Carlos Garcia Campos]

Created attachment 453972 [details]
Patch

This won't apply as it's based on bug #237516

[Michael Catanzaro]

Comment on attachment 453972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
> +#openFile {
> +    display: none !important;
> +}

Is the file chooser not working?

> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
> +.dropdownToolbarButton > select {
> +    -webkit-appearance: none;
> +}

Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure.

[Carlos Garcia Campos]

Comment on attachment 453972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453972&action=review

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:27
>> +}
> 
> Is the file chooser not working?

Yes, opening files results in an error message. I don't know why, but I'm not sure we want to provide that functionality either.

>> Source/WebCore/Modules/pdfjs-extras/adwaita/style.css:31
>> +}
> 
> Hm, honestly I don't remember exactly what this hack was used for, other than to hide something that was broken in Epiphany. Jan-Michael might remember for sure.

This is not hiding anything, this is telling WebKit not to use the native appearance for the zoom combo box in the toolbar, because the adwaita one is bigger and doesn't look right. Hopefully Alexander can add customizations here to make it look great and consistent with adwaita.

[Carlos Garcia Campos]

Committed r291096 (248258@trunk): <https://commits.webkit.org/248258@trunk>